MantisBT - Community
View Issue Details
0022844Community[OCCT] OCCT:Visualizationpublic2011-12-13 16:552012-03-29 17:26
szy 
bugmaster 
normalminor 
closedfixed 
ALL
[OCCT] 6.5.2 
[OCCT] 6.5.3[OCCT] 6.5.3 
Test case is not required
0022844: Bug in Select2d_SensitiveSegment
Post from the Forum (Massimo Del Fedele) - http://www.opencascade.org/org/forum/thread_22337/. [^]
"Here :

Standard_Boolean Select2D_SensitiveSegment::
Matches (const Standard_Real XMin,
      const Standard_Real YMin,
      const Standard_Real XMax,
      const Standard_Real YMax,
      const Standard_Real aTol)
{
Standard_Real TheTol = HasOwnTolerance()? myOwnTolerance : aTol;

Bnd_Box2d BoundBox;
BoundBox.Update(XMin-TheTol,YMin-TheTol,XMax+TheTol,YMax+TheTol);

if (BoundBox.IsOut(mystart)&&BoundBox.IsOut(myend)) return Standard_False;
return Standard_True;
}

the function returns true if ONE of both segment ends is inside given rectangle; it should return true
if BOTH ends are inside box, so the && should be replaced with ||.

Max"
================
It is confirmed by SAN that it is a bug.
This is clearly a typo so test case is not needed.
Mistyping in Standard_Boolean Select2D_SensitiveSegment::Matches(xmin, ymin, xmax, ymax) corrected, now this method returns Standard_True only when both ends are inside the selection rectangle.
No tags attached.
Issue History
2011-12-13 16:55szyNew Issue
2011-12-13 16:55szyAssigned To => san
2012-02-21 17:54sanStatusnew => assigned
2012-02-21 18:00sanDescription Updatedbug_revision_view_page.php?rev_id=3525#r3525
2012-02-21 18:00sanAdditional Information Updatedbug_revision_view_page.php?rev_id=3527#r3527
2012-02-21 18:01sanStatusassigned => resolved
2012-02-21 18:03sanNote Added: 0019707
2012-02-21 18:03sanAssigned Tosan => bugmaster
2012-02-21 18:03sanStatusresolved => reviewed
2012-02-21 19:02mkvAssigned Tobugmaster => mkv
2012-02-22 14:50mkvNote Added: 0019729
2012-02-22 14:50mkvTest case number => Test case is not required
2012-02-22 14:50mkvAssigned Tomkv => bugmaster
2012-02-22 14:50mkvStatusreviewed => tested
2012-02-22 16:51bugmasterNote Added: 0019742
2012-02-22 16:51bugmasterStatustested => verified
2012-02-22 16:51bugmasterResolutionopen => fixed
2012-02-22 16:51bugmasterAssigned Tobugmaster => szy
2012-03-29 17:26bugmasterChangeset attached => occt master 695bdd1b

Notes
(0019707)
san   
2012-02-21 18:03   
SVN branch OCC22844 is ready for testing.
(0019729)
mkv   
2012-02-22 14:50   
Dear BugMaster,
Workbench KAS:dev:mkv-22844-occt was created from SVN branch http://svn/svn/occt/branches/OCC22844 [^]
(and mkv-22844-products from trunk) and compiled on Linux platform.

There are not regressions in mkv-22844-products regarding to KAS:dev:products-20120217-opt

See results in /QADisk/occttests/results/KAS/dev/mkv-22844-products_21022012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120217-opt_17022012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification [^]
(0019742)
bugmaster   
2012-02-22 16:51   
Integrated into trunk of occt repository

Date: 2012-02-22 16:49:54 +0400 (Wed, 22 Feb 2012)
New Revision: 10600

Modified:
   trunk/src/Select2D/Select2D_SensitiveSegment.cxx