MantisBT - Community
View Issue Details
0022572Community[OCCT] OCCT:Data Exchangepublic2011-06-03 14:172012-03-29 17:26
szy 
bugmaster 
normalfeature 
closedfixed 
All
 
[OCCT] 6.5.2[OCCT] 6.5.2 
chl 937 C5
0022572: Support of progress indicator in RWStl and optimization of reading Ascii.
fix225
- Summary: Support of progress indicator in RWStl and optimization of reading Ascii.
Detailed description:
      - Progress indicator added to Write...(), Read...().
      - reduction of string buffers reallocation when writing STL files in ascii
mode
No tags attached.
parent of 0022760closed bugmaster Open CASCADE Regression in the method RWStl::WriteAscii 
child of 0022825closed abv Community Integration of contributions by Roman Lygin to OCCT 6.5.2 
gz chl_937_C5.tar.gz (601) 2011-07-12 14:24
https://tracker.dev.opencascade.org/
Issue History
2011-07-05 18:10kgvCC => kgv
2011-07-13 11:56bugmasterStatusclosed => assigned
2011-07-13 11:56bugmasterResolutionsuspended => @0@
2011-07-13 11:56bugmasterAssigned Tobugmaster => kgv
2011-07-13 11:56bugmasterStatusassigned => tested
2011-07-13 11:57bugmasterStatustested => verified
2011-07-29 15:32bugmasterFixed in VersionEMPTY =>
2011-07-29 15:32bugmasterTarget Version => 6.5.2
2011-07-29 15:32bugmasterDescription Updatedbug_revision_view_page.php?rev_id=122#r122
2011-08-02 11:12bugmasterCategoryOCCT:DTE => OCCT:Data Exchange
2011-09-07 17:15mkvTest case number => chl 937 C5
2011-10-13 16:48abvRelationship addedparent of 0022760
2011-11-22 12:01szyNote Edited: 0017593bug_revision_view_page.php?bugnote_id=17593#r873
2011-11-22 17:35szyNote Edited: 0017595bug_revision_view_page.php?bugnote_id=17595#r881
2011-12-05 11:24abvRelationship addedchild of 0022825
2012-01-17 18:35abvAssigned Tokgv => Roman Lygin
2012-03-29 17:26bugmasterChangeset attached => occt master 9c6afe19

Notes
(0017590)
kgv   
2011-06-10 15:35   
SVN branch http://svn/svn/occt/branches/OCC22572_RWStlPrIndicator [^] for this BUG
was superficially reviewed.
- Original patch based on out-dated version of sources (thus directly applied
on recent revision will contain changes unrealted to fix).
- Generally when user interrupt function execution (using progress indiactor
interface) this function should return fail code rather then success.
- RWStl.cdl was uploaded to branch with CRLF endlines.
(0017591)
kgv   
2011-06-10 16:52   
Additional remark: meshfromstl DRAWEXE command was not updated to use
introduced progress indicator.

All remarks should be fixed and new code revision is needed.
(0017592)
kgv   
2011-06-10 16:56   
All remarks was fixed and integrated into bug branch.
Introduced progress indicator can be tested with this DRAWEXE scenario:

pload ALL;
vinit;
XProgress -t -g;
meshfromstl m1 bearing.stl;
XProgress +t +g;
meshfromstl m2 bearing.stl;

At second meshfromstl progress should be shown.

Patch is ready for testing (should be retrieved from SVN
http://svn/svn/occt/branches/OCC22572_RWStlPrIndicator [^]).
(0017593)
ycy   
2011-07-11 16:12   
(edited on: 2011-11-22 12:01)
Dear,Kirill
Please attach file "bearing.stl"
Regards,
Yuri.

(0017594)
kgv   
2011-07-11 17:06   
2Yuri,
this STL file is placed in OCCT/data/stl/ path within standard OCCT installation.
(0017595)
ycy   
2011-07-12 16:23   
(edited on: 2011-11-22 17:35)
Dear BugMaster,
SVN branch (http://svn/svn/occt/branches/OCC22572_RWStlPrIndicator [^]) was
testing, test results were compared with KAS:dev:products-651-opt

regressions were not found
Test case for this bug (chl/937/C5)

improvements chl 937 C5

See results in /QADisk/OCCTtests/KAS/dev/ycy-products-3_08072011/lin
See reference results in
/QADisk/occttests/results/KAS/dev/products-651-opt_01062011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://sbu.nnov.opencascade.com/maintenance/main_certification_te.html [^]

(0017597)
bugmaster   
2011-07-13 11:57   
Fix has been integrated to occt repository

Date: 2011-07-12 21:24:21 +0400 (Tue, 12 Jul 2011)
New Revision: 8671

Modified:
   trunk/src/RWStl/RWStl.cdl
   trunk/src/RWStl/RWStl.cxx
   trunk/src/XSDRAWSTLVRML/XSDRAWSTLVRML.cxx