MantisBT - Community
View Issue Details
0022325Community[OCCT] OCCT:Foundation Classespublic2011-03-16 16:552016-04-20 15:51
szy 
bugmaster 
normaltrivial 
closedfixed 
All
[OCCT] 6.9.1 
[OCCT] 7.0.0[OCCT] 7.0.0 
Not needed
0022325: Patch to fix a build failure on GNU/kFreeBSD
Post from forum
http://www.opencascade.org/org/forum/thread_20052/ [^]

"Hello, here is a patch to fix a build failure on GNU/kFreeBSD
Denis Barbier "
N/A
No tags attached.
patch kfreebsd.patch (698) 2011-11-24 10:36
https://tracker.dev.opencascade.org/
Issue History
2011-03-18 17:05bugmasterStatusclosed => assigned
2011-03-18 17:05bugmasterResolutionsuspended => @0@
2011-03-18 17:05bugmasterAssigned Tobugmaster => inv
2011-08-02 11:23bugmasterCategoryOCCT:FDC => OCCT:Foundation Classes
2011-11-24 10:35szyFixed in VersionEMPTY =>
2011-11-24 10:35szyDescription Updatedbug_revision_view_page.php?rev_id=960#r960
2011-11-24 10:36szyFile Added: kfreebsd.patch
2015-11-01 11:58gitNote Added: 0047680
2015-11-01 11:58abvAssigned Toinv => abv
2015-11-01 11:58abvStatusassigned => resolved
2015-11-01 11:58abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12061#r12061
2015-11-01 11:59abvNote Added: 0047681
2015-11-01 11:59abvAssigned Toabv => bugmaster
2015-11-01 11:59abvStatusresolved => reviewed
2015-11-01 13:04kgvNote Added: 0047685
2015-11-01 13:05kgvProduct Version => 6.9.1
2015-11-01 13:05kgvTarget Version => 7.0.0
2015-11-01 14:31gitNote Added: 0047688
2015-11-01 14:32abvNote Added: 0047689
2015-11-02 12:16mkvAssigned Tobugmaster => mkv
2015-11-02 19:19mkvNote Added: 0047736
2015-11-02 19:19mkvAssigned Tomkv => abv
2015-11-02 19:19mkvStatusreviewed => assigned
2015-11-02 19:19mkvTest case number => Not needed
2015-11-02 19:19mkvNote Added: 0047737
2015-11-02 19:28kgvNote Added: 0047738
2015-11-02 19:28kgvNote Edited: 0047738bug_revision_view_page.php?bugnote_id=47738#r12101
2015-11-05 11:25kgvAssigned Toabv => bugmaster
2015-11-05 11:25kgvStatusassigned => feedback
2015-11-05 11:40bugmasterNote Added: 0047797
2015-11-05 11:40bugmasterStatusfeedback => tested
2015-11-05 11:40bugmasterNote Edited: 0047797bug_revision_view_page.php?bugnote_id=47797#r12117
2015-11-06 12:35bugmasterChangeset attached => occt master a5916aa2
2015-11-06 12:35bugmasterStatustested => verified
2015-11-06 12:35bugmasterResolutionopen => fixed
2016-04-17 14:26gitNote Added: 0053163
2016-04-20 15:42aivFixed in Version => 7.0.0
2016-04-20 15:51aivStatusverified => closed

Notes
(0047680)
git   
2015-11-01 11:58   
Branch CR22325 has been created by abv.

SHA-1: 8f8c329323f5644cf6fc9bbd8ea87cc54bfd2cef


Detailed log of new commits:

Author: abv
Date: Sun Nov 1 11:57:26 2015 +0300

    0022325: Patch to fix a build failure on GNU/kFreeBSD
(0047681)
abv   
2015-11-01 11:59   
Please integrate CR22325, no testing is required
(0047685)
kgv   
2015-11-01 13:04   
The patch overlaps with tested #0026823 - it is better to rebase it.
(0047688)
git   
2015-11-01 14:31   
Branch CR22325 has been updated forcibly by abv.

SHA-1: e6dd8a302ecac679c6b5a3763dd4a8597c79a647
(0047689)
abv   
2015-11-01 14:32   
CR22325 is updated to include fix made for #26823
(0047736)
mkv   
2015-11-02 19:19   
Dear BugMaster,
Branch CR22325 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested on Release mode.
SHA-1: e6dd8a302ecac679c6b5a3763dd4a8597c79a647

Number of compiler warnings:

occt component :
Linux: 0 (0 on master)
Windows: 0 (0 on master)
MacOS : 149 (146 on master)

products component :
Linux: 39 (39 on master)
Windows: 0 (0 on master)

There is new additional compilation warnings on MacOS platform:
http://jenkins-test-01.nnov.opencascade.com:8080/user/mnt/my-views/view/A_mnt_warnings/portlet/dashboard_portlet_17008/job/CR22325-master_prepare_build_occt_MacOS/1/warnings7Result/package.1721264642/ [^]
OSD.cxx:132, Clang (LLVM based), Priority: Normal
'finite' is deprecated: first deprecated in OS X 10.9
OSD.cxx:136, Clang (LLVM based), Priority: Normal
'finite' is deprecated: first deprecated in OS X 10.9
OSD_Directory.cxx:65, Clang (LLVM based), Priority: Normal
'tmpnam' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of tmpnam(3), it is highly recommended that you use mkstemp(3) instead.

Regressions/Differences/Improvements:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
occt component :
Total MEMORY difference: 92413635 / 92242996 [+0.18%]
Total CPU difference: 19748.299999999737 / 19674.139999999712 [+0.38%]
products component :
Total MEMORY difference: 26207444 / 26253190 [-0.17%]
Total CPU difference: 7472.489999999993 / 7355.5300000000125 [+1.59%]

Testing on Windows:
occt component :
Total MEMORY difference: 58011233 / 58031587 [-0.04%]
Total CPU difference: 18206.034304598834 / 18265.314684598936 [-0.32%]
products component :
Total MEMORY difference: 17160312 / 17165819 [-0.03%]
Total CPU difference: 5553.0895964999545 / 5706.4541795999685 [-2.69%]

There are no differences in images found by testdiff.
(0047737)
mkv   
2015-11-02 19:19   
Dear abv,
Branch CR22325 has been rejected due to:
- additional warnings on MacOS platform
(0047738)
kgv   
2015-11-02 19:28   
OSD_Directory.cxx:65, Clang (LLVM based), Priority: Normal
'tmpnam' is deprecated:

this is not a new warning - it is already registered as 0026179.

OSD.cxx:132, Clang (LLVM based), Priority: Normal
'finite' is deprecated: first deprecated in OS X 10.9

these warning is most likely caused by the following change in #0026823:
-#include <math.h>
+#include <cmath>

It should be probably subject for dedicated bug.

(0047797)
bugmaster   
2015-11-05 11:40   
issue 0026843 has been registered for warnings:
OSD.cxx:132, Clang (LLVM based), Priority: Normal
'finite' is deprecated: first deprecated in OS X 10.9
OSD.cxx:136, Clang (LLVM based), Priority: Normal
'finite' is deprecated: first deprecated in OS X 10.9

(0053163)
git   
2016-04-17 14:26   
Branch CR22325 has been deleted by kgv.

SHA-1: e6dd8a302ecac679c6b5a3763dd4a8597c79a647