occt: master 03275c0b

Diff Back to Repository
Author Committer Branch Timestamp Parent
ddzama smoskvin master 2022-10-21 16:28:30 master 2f33e340
Affected Issues  0022821: Crash with BRepFilletAPI_MakeFillet
Changeset 0022821: Crash with BRepFilletAPI_MakeFillet

test bugs modalg_7 bug22821 failed on fillet shape with 5-th edge.
Experimentally has been found that reducing of parameter
ChFi3d_Builder::tolesp for this task solves the issue.

So, as soluton it is proposed to link parameter toleps with parameter range of
spine curve. So, production coefficient has been set to pass all tests and
2 teset was extended: tests/blend/complex/A6, tests/bugs/modalg_7/bug22821

first has been extended to test different scaling factors,
second has been extended to make fillet on all edges from 12.

Additionally:
 - fixed misusage of tolesp in contexts where tolerance of point in 3d is excepted;
     In some context usage of tol_esp is irrelevant, because its essentiality - tolerance of the parameter on the 3d curve.
     So, in such context it has been replaced with new parameter tol3d (with fix value 1.0e-4).
     Get rid of tolapp3d duplication constant - tol_3d
 - tolesp = 5.0e-5 * (umax - umin)
 - tolesp replaced by tolpoint2d/tolpoint3d in several classes.
     Blend_Walking
     BRepBlend_SurfRstLineBuilder
     BRepBlend_RstRstLineBuilder
     Blend_CSWalking
     Instead `tolesp` - `tolgui` is employed in contexts where tolerance of guide curve parameter is excepted.
     Instead `tolesp` - `tolpoint2d` or `tolpoint3d` is employed in contexts where tolerance of point in 2d or 3d space is excepted.
 - Replace tolesp with tolpoint2d/tolpoint3d in BBPP function argument.
 - Use tolapp3d instead tolesp in BonVoisin function,
mod - src/Blend/Blend_CSWalking_1.gxx Diff File
mod - src/Blend/Blend_CSWalking_2.gxx Diff File
mod - src/Blend/Blend_CSWalking_3.gxx Diff File
mod - src/Blend/Blend_CSWalking_4.gxx Diff File
mod - src/Blend/Blend_Walking_1.gxx Diff File
mod - src/Blend/Blend_Walking_2.gxx Diff File
mod - src/Blend/Blend_Walking_3.gxx Diff File
mod - src/Blend/Blend_Walking_4.gxx Diff File
mod - src/BRepBlend/BRepBlend_CSWalking.hxx Diff File
mod - src/BRepBlend/BRepBlend_RstRstLineBuilder.cxx Diff File
mod - src/BRepBlend/BRepBlend_RstRstLineBuilder.hxx Diff File
mod - src/BRepBlend/BRepBlend_SurfRstLineBuilder.cxx Diff File
mod - src/BRepBlend/BRepBlend_SurfRstLineBuilder.hxx Diff File
mod - src/BRepBlend/BRepBlend_Walking.hxx Diff File
mod - src/BRepFilletAPI/BRepFilletAPI_MakeFillet.cxx Diff File
mod - src/BRepTest/BRepTest_FeatureCommands.cxx Diff File
mod - src/BRepTest/BRepTest_FilletCommands.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder.hxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_1.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_2.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_6.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_C1.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_C2.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_CnCrn.cxx Diff File
mod - src/ChFi3d/ChFi3d_Builder_SpKP.cxx Diff File
mod - src/ChFi3d/ChFi3d_ChBuilder.cxx Diff File
mod - src/ChFi3d/ChFi3d_ChBuilder_C3.cxx Diff File
mod - src/ChFi3d/ChFi3d_FilBuilder.cxx Diff File
mod - src/ChFi3d/ChFi3d_FilBuilder_C2.cxx Diff File
mod - src/ChFi3d/ChFi3d_FilBuilder_C3.cxx Diff File
mod - src/ChFiDS/ChFiDS_Spine.cxx Diff File
mod - src/ChFiDS/ChFiDS_Spine.hxx Diff File
mod - src/ChFiDS/ChFiDS_Spine.lxx Diff File
mod - src/FilletSurf/FilletSurf_InternalBuilder.cxx Diff File
mod - src/QABugs/QABugs_11.cxx Diff File
mod - src/QABugs/QABugs_17.cxx Diff File
mod - src/ViewerTest/ViewerTest_FilletCommands.cxx Diff File
mod - tests/blend/complex/A6 Diff File
mod - tests/bugs/modalg_7/bug22821 Diff File