occt: master a453f9d1

Diff Back to Repository
Author Committer Branch Timestamp Parent
atereshi smoskvin master 2022-09-20 11:48:14 master 492b09dc
Affected Issues  0028414: Data Exchange - Step entity not correctly read
Changeset 0028414: Data Exchange, STEP - Face on a closed surface with single inner wire and without natural bound not correctly read

Problem: From the point of view of the STEP format (and others), it is allowed
to describe a face on a surface with natural boundaries (torus, sphere) without
specifying these boundaries. Thus, a face on a closed surface and containing
an inner wire (or several) is correctly defined and describes a face with a
cutout defined by this wire. At the same time, there is a function
(ShapeFix_Face::FixOrientation) in the ShapeHealing procedure that corrects the
orientation of the wires, and it starts before the function of adding natural
boundaries (ShapeFix_Face::FixAddNaturalBound). There are many shapes that have
incorrectly oriented wires and this procedure successfully heals them, but on a
correctly specified face with single inner wire on closed surface, we do not get
the entire surface with a cutout, but a part of the surface defined by the wire.
This fix is intended to resolve this ambiguity.

Change:
1. Added function isNeedAddNaturalBound that returns TRUE if face needs to add
 natural bounds.
2. Corrected condition in FixOrientation to ignoring faces that needs to add
 natural bounds.
3. For tests in which one wire was incorrectly oriented on a closed surface,
flag AddNaturalBound was disabled.
5. Test with cutout from torus was created: bugs step bug28414.

Result: By default, it is correct to add natural boundaries, because this case
 is correct from the point of view of the STEP format and others.
mod - src/ShapeFix/ShapeFix_Face.cxx Diff File
mod - src/ShapeFix/ShapeFix_Face.hxx Diff File
mod - tests/bugs/begin Diff File
mod - tests/bugs/modalg_7/bug30273 Diff File
add - tests/bugs/step/bug28414 Diff File
mod - tests/bugs/step/bug32922 Diff File
mod - tests/bugs/xde/bug6283 Diff File
mod - tests/de/begin Diff File
mod - tests/de/end Diff File
mod - tests/de/iges_1/G8 Diff File
mod - tests/de/iges_1/J9 Diff File
mod - tests/de/step_1/E1 Diff File
mod - tests/de/step_1/E2 Diff File
mod - tests/de/step_1/G9 Diff File
mod - tests/de/step_1/J6 Diff File
mod - tests/de/step_2/B3 Diff File
mod - tests/de/step_2/Q5 Diff File
mod - tests/de/step_2/Q6 Diff File
mod - tests/de/step_3/B9 Diff File
mod - tests/de/step_3/C8 Diff File
mod - tests/de/step_3/E4 Diff File