occt: master 3510db62

Diff Back to Repository
Author Committer Branch Timestamp Parent
msv bugmaster master 2015-10-21 09:36:03 master 6435b9c7
Changeset 0026619: Tolerances of operands are modified using bop

0026796: The result of General Fuse operation is self-intersecting shape

The fix forces creation of new sub-shapes (vertex, edge) when the tolerance of some sub-shape of an argument is to be increased.

This new behavior is turned off by default. It can be turned on using two ways:
1) Setting 'locking' flag of the arguments.
2) Calling the method SetNonDestructive(Standard_True) of the API classes.

Various bug fixes in the algorithm:
- Compute correct tolerance values for intersections of type Line/Line, Line/Plane, Plane/Plane.
- In case of Line/Plane intersection check if line's vertices lie on the plane.
- Do not allow decreasing of the tolerance value of the Line/Line intersection vertex.
- In IntTools_EdgeEdge, call the method FindParameters with proper 3D tolerance of the curve.
- Force making copy of a degenerated edge if its vertex is touched but no 2D intersection with other curves is found.
- Remove pave blocks both ends of which became referring to the same vertex after vertices substitution.
- Avoid exception in IntTools_Context::IsVertexOnLine if Extrema is not done.
- Reduce tolerance of vertex/edge using actual distances to interfered shapes if it was increased due to line/line, line/plane, or plane/plane small intersection angle.
- Update tolerance of edges to reach all representations in a common block.
- In V-E intersections, check if a vertex hits beyond shrunk range, in such case create V-V interference.
- Do not put a section edge to the result if it becomes to be a micro edge after updating its vertex.
- Correctly make vertices same-domain during the work of MakeBlocks.
- Decrease shrunk range at least on a Precision::Confusion() in addition to vertex tolerance.
- Add Confusion to bounding boxes of new shapes in DS
- Add tolerance Precision::Confusion() to compare distances of touching cases to fix regressions.

TODO marks have been removed from (or modified in) the following test cases (Improvements):
boolean bsection M3 N2 R2
boolean gdml_private B6 C2 C6 G7 I6 F6 J1 J4 M7 N1 N8 N9 O3 O4 O6 O8 O9 P1 P2 P5 Q1 Q3 Q5 S9 T2 U4 U5 U9 ZB5 ZB6 ZC1 ZC5 ZD3 ZD6 ZD7 ZH2 ZH5 ZI2 ZI5 ZI7 ZI9 ZJ3 ZJ4 ZJ7 F8 I6 G1
boolean volumemaker A5 A6 B3 B4 B7 B9 D3 D4 D7 F1
boolean bopcut_2d D5
bugs modalg_5 bug25043
bugs modalg_2 bug472_1 bug472_2 bug472_3

Test cases updated because they are still bad but can be accepted as non-regression:
boolean volumemaker C4 A3 A7 E6
bugs modalg_1 bug10232
boolean bsection N2

Put new TODO in the scripts:
bugs modalg_5 bug25232_9
bugs modalg_6 bug26619
bugs modalg_1 buc60462_2
bugs modalg_4 bug772

For the following tests the result in fix became better, so take fix result as the reference:
bugs modalg_5 bug24628
bugs modalg_6 bug26954_3
boolean volumemaker A4 B5 B6 C3 C8 D2 D5 F2
bugs modalg_2 bug472_2
bugs modalg_1 buc60776_1

- Add the method SetNonDestructive to API classes of user level
mod - src/BOPAlgo/BOPAlgo_BOP.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_Builder.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_Builder.hxx Diff File
mod - src/BOPAlgo/BOPAlgo_Builder_1.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_Builder_2.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_Builder_3.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_CheckerSI.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_CheckerSI.hxx Diff File
mod - src/BOPAlgo/BOPAlgo_MakerVolume.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller.hxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_1.cxx Diff File
add - src/BOPAlgo/BOPAlgo_PaveFiller_11.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_2.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_3.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_4.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_5.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_6.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_7.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_8.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_PaveFiller_9.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_Tools.cxx Diff File
mod - src/BOPAlgo/BOPAlgo_Tools.hxx Diff File
mod - src/BOPAlgo/BOPAlgo_WireSplitter_1.cxx Diff File
mod - src/BOPAlgo/FILES Diff File
mod - src/BOPDS/BOPDS_CommonBlock.cxx Diff File
mod - src/BOPDS/BOPDS_CommonBlock.hxx Diff File
mod - src/BOPDS/BOPDS_CoupleOfPaveBlocks.hxx Diff File
mod - src/BOPDS/BOPDS_DS.cxx Diff File
mod - src/BOPDS/BOPDS_DS.hxx Diff File
mod - src/BOPDS/BOPDS_Interf.hxx Diff File
mod - src/BOPTest/BOPTest_APICommands.cxx Diff File
mod - src/BOPTest/BOPTest_BOPCommands.cxx Diff File
mod - src/BOPTest/BOPTest_Objects.cxx Diff File
mod - src/BOPTest/BOPTest_Objects.hxx Diff File
mod - src/BOPTest/BOPTest_OptionCommands.cxx Diff File
mod - src/BOPTest/BOPTest_PartitionCommands.cxx Diff File
mod - src/BOPTools/BOPTools_AlgoTools.cxx Diff File
mod - src/BOPTools/BOPTools_AlgoTools.hxx Diff File
mod - src/BOPTools/BOPTools_AlgoTools_1.cxx Diff File
mod - src/BRepAlgoAPI/BRepAlgoAPI_BooleanOperation.cxx Diff File
mod - src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.cxx Diff File
mod - src/BRepAlgoAPI/BRepAlgoAPI_BuilderAlgo.hxx Diff File
mod - src/IntTools/IntTools_BeanFaceIntersector.cxx Diff File
mod - src/IntTools/IntTools_Context.cxx Diff File
mod - src/IntTools/IntTools_Context.hxx Diff File
mod - src/IntTools/IntTools_EdgeEdge.cxx Diff File
mod - src/IntTools/IntTools_EdgeEdge.hxx Diff File
mod - src/IntTools/IntTools_EdgeFace.cxx Diff File
mod - src/IntTools/IntTools_FaceFace.cxx Diff File
mod - src/IntTools/IntTools_FaceFace.hxx Diff File
mod - src/IntTools/IntTools_ShrunkRange.cxx Diff File
mod - src/IntTools/IntTools_Tools.cxx Diff File
mod - src/IntTools/IntTools_Tools.hxx Diff File
mod - src/QABugs/QABugs_19.cxx Diff File
mod - tests/boolean/bopcut_2d/D5 Diff File
mod - tests/boolean/bsection/M3 Diff File
mod - tests/boolean/bsection/N2 Diff File
mod - tests/boolean/bsection/R2 Diff File
mod - tests/boolean/gdml_private/B6 Diff File
mod - tests/boolean/gdml_private/C2 Diff File
mod - tests/boolean/gdml_private/C6 Diff File
mod - tests/boolean/gdml_private/F6 Diff File
mod - tests/boolean/gdml_private/F8 Diff File
mod - tests/boolean/gdml_private/G1 Diff File
mod - tests/boolean/gdml_private/G7 Diff File
mod - tests/boolean/gdml_private/H7 Diff File
mod - tests/boolean/gdml_private/I6 Diff File
mod - tests/boolean/gdml_private/J1 Diff File
mod - tests/boolean/gdml_private/J4 Diff File
mod - tests/boolean/gdml_private/M7 Diff File
mod - tests/boolean/gdml_private/N1 Diff File
mod - tests/boolean/gdml_private/N8 Diff File
mod - tests/boolean/gdml_private/N9 Diff File
mod - tests/boolean/gdml_private/O1 Diff File
mod - tests/boolean/gdml_private/O3 Diff File
mod - tests/boolean/gdml_private/O4 Diff File
mod - tests/boolean/gdml_private/O6 Diff File
mod - tests/boolean/gdml_private/O8 Diff File
mod - tests/boolean/gdml_private/O9 Diff File
mod - tests/boolean/gdml_private/P1 Diff File
mod - tests/boolean/gdml_private/P2 Diff File
mod - tests/boolean/gdml_private/P5 Diff File
mod - tests/boolean/gdml_private/Q1 Diff File
mod - tests/boolean/gdml_private/Q3 Diff File
mod - tests/boolean/gdml_private/Q5 Diff File
mod - tests/boolean/gdml_private/S9 Diff File
mod - tests/boolean/gdml_private/T2 Diff File
mod - tests/boolean/gdml_private/U4 Diff File
mod - tests/boolean/gdml_private/U5 Diff File
mod - tests/boolean/gdml_private/U9 Diff File
mod - tests/boolean/gdml_private/ZB5 Diff File
mod - tests/boolean/gdml_private/ZB6 Diff File
mod - tests/boolean/gdml_private/ZC1 Diff File
mod - tests/boolean/gdml_private/ZC5 Diff File
mod - tests/boolean/gdml_private/ZD3 Diff File
mod - tests/boolean/gdml_private/ZD6 Diff File
mod - tests/boolean/gdml_private/ZD7 Diff File
mod - tests/boolean/gdml_private/ZH2 Diff File
mod - tests/boolean/gdml_private/ZH5 Diff File
mod - tests/boolean/gdml_private/ZI2 Diff File
mod - tests/boolean/gdml_private/ZI5 Diff File
mod - tests/boolean/gdml_private/ZI7 Diff File
mod - tests/boolean/gdml_private/ZI9 Diff File
mod - tests/boolean/gdml_private/ZJ3 Diff File
mod - tests/boolean/gdml_private/ZJ4 Diff File
mod - tests/boolean/gdml_private/ZJ7 Diff File
mod - tests/boolean/volumemaker/A3 Diff File
mod - tests/boolean/volumemaker/A4 Diff File
mod - tests/boolean/volumemaker/A5 Diff File
mod - tests/boolean/volumemaker/A6 Diff File
mod - tests/boolean/volumemaker/A7 Diff File
mod - tests/boolean/volumemaker/B3 Diff File
mod - tests/boolean/volumemaker/B4 Diff File
mod - tests/boolean/volumemaker/B5 Diff File
mod - tests/boolean/volumemaker/B6 Diff File
mod - tests/boolean/volumemaker/B7 Diff File
mod - tests/boolean/volumemaker/B9 Diff File
mod - tests/boolean/volumemaker/C2 Diff File
mod - tests/boolean/volumemaker/C3 Diff File
mod - tests/boolean/volumemaker/C4 Diff File
mod - tests/boolean/volumemaker/C8 Diff File
mod - tests/boolean/volumemaker/C9 Diff File
mod - tests/boolean/volumemaker/D1 Diff File
mod - tests/boolean/volumemaker/D2 Diff File
mod - tests/boolean/volumemaker/D3 Diff File
mod - tests/boolean/volumemaker/D4 Diff File
mod - tests/boolean/volumemaker/D5 Diff File
mod - tests/boolean/volumemaker/D7 Diff File
mod - tests/boolean/volumemaker/E6 Diff File
mod - tests/boolean/volumemaker/F1 Diff File
mod - tests/boolean/volumemaker/F2 Diff File
mod - tests/bugs/modalg_1/buc60462_2 Diff File
mod - tests/bugs/modalg_1/buc60776_1 Diff File
mod - tests/bugs/modalg_1/bug10232 Diff File
mod - tests/bugs/modalg_2/bug472_1 Diff File
mod - tests/bugs/modalg_2/bug472_2 Diff File
mod - tests/bugs/modalg_2/bug472_3 Diff File
mod - tests/bugs/modalg_4/bug772 Diff File
mod - tests/bugs/modalg_5/bug24628 Diff File
mod - tests/bugs/modalg_5/bug25043 Diff File
mod - tests/bugs/modalg_5/bug25232_9 Diff File
add - tests/bugs/modalg_6/bug26619 Diff File
mod - tests/bugs/modalg_6/bug26954_3 Diff File