View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0033378 | Open CASCADE | OCCT:Configuration | public | 2023-05-15 09:42 | 2023-05-22 03:17 |
| Reporter | dpasukhi | Assigned To | dpasukhi | ||
| Priority | normal | Severity | feature | ||
| Status | verified | Resolution | fixed | ||
| Product Version | 7.7.0 | ||||
| Target Version | 7.7.2 | ||||
| Summary | 0033378: Configuration - Moving ExpToCas into separate module | ||||
| Description | ExpToCas is not a part of DE module. It is a special tool for rare cases. | ||||
| Steps To Reproduce | Not applicable | ||||
| Tags | No tags attached. | ||||
| Test case number | |||||
|
|
Branch CR33378 has been created by dpasukhi. SHA-1: 2b1f3daa22ab99acfa9865ad8b5b11311de828c1 Detailed log of new commits: Author: dpasukhi Date: Mon May 15 08:11:45 2023 +0100 0033378: Configuration - Moving ExpToCas into separate module Moved Exe and its DLL to new module - DETools Created new module - DETools to keep tools to DE Changed definition of main of ExpToCasExe to not const parameter |
|
|
Branch CR33378 has been updated forcibly by dpasukhi. SHA-1: 3259f45e48c8df59d79fa2e14e08918747bf0ae5 |
|
|
Branch CR33378 has been updated forcibly by dpasukhi. SHA-1: dfec073c07f99ccc6302473ed33dc0a80dd95c8f |
|
|
Branch CR33378 has been updated by dpasukhi. SHA-1: 4e4156feb7a34306cbf306c8f10ff8e4b772e2ea Detailed log of new commits: Author: dpasukhi Date: Mon May 15 09:50:50 2023 +0100 // moving FlexLexer to general location |
|
|
Branch CR33378 has been updated forcibly by dpasukhi. SHA-1: 73024a772df9187992a41452ecabebb46c2afce5 |
|
|
Branch CR33378 has been updated forcibly by dpasukhi. SHA-1: 3774f3b8ddfd1f991d092b336a63105e7b958320 |
|
|
Dear ika, please review CR33378 Builds are correct, see: http://jenkins-test-10.nnov.opencascade.com/view/CR33378-master-dpasukhi/view/OCCT%20compile/ I just move out ExpToCasExe and TKExpress into new module. The main reason - problem with build on static mode and some OS or env. And the other reason, this exe is not a part of DE. It is not needed for the most part of users. |
|
|
Dear dpasukhi, I have only one remark: cmake/occt_toolkit.cmake + # remove old general version of FlexLexer + if (EXISTS ${FLEX_BISON_TARGET_DIR}/FlexLexer.h) + message (STATUS "Info: remove old FLEX header file: ${CMAKE_SOURCE_DIR}/${RELATIVE_SOURCES_DIR}/FlexLexer/FlexLexer.h") + file(REMOVE ${CMAKE_SOURCE_DIR}/${RELATIVE_SOURCES_DIR}/FlexLexer/FlexLexer.h) + endif() so the check is in one place and the deleting is from another. |
|
|
Branch CR33378 has been updated by dpasukhi. SHA-1: 0db8fad5d8d4e92a2195eb36650f56fdf33d2cd6 Detailed log of new commits: Author: dpasukhi Date: Wed May 17 16:10:13 2023 +0100 // fixed FlexLexer.h path to check for review |
|
|
Branch CR33378_1 has been created by dpasukhi. SHA-1: 758cad3a7320f038b8e3f8004ddb7e19e3d6ff28 Detailed log of new commits: Author: dpasukhi Date: Mon May 15 08:11:45 2023 +0100 0033378: Configuration - Moving ExpToCas into separate module Moved ExpToCasExe and its DLL to new module - DETools Created new module - DETools to keep tools to DE Changed definition of main of ExpToCasExe to not const parameter FlexLexer.h moved to general location into TKernel |
|
|
Dear ika, remarks have been fixed: see CR33378 New combined branch: CR33378_1 There is not possible to test new changes on our test system. |
|
|
No more remarks. Dear bugmaster, please integrate OCCT: CR33378_1 |
|
|
Combination - OCCT branch : IR-2023-05-19 Products branch : IR-2023-05-19 was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Ubuntu2004-64: OCCT Total CPU difference: 18391.170000000107 / 18189.450000000208 [+1.11%] Products Total CPU difference: 12017.159999999963 / 12137.909999999983 [-0.99%] Windows-64-VC142: OCCT Total CPU difference: 20046.90625 / 19812.3125 [+1.18%] Products Total CPU difference: 14550.09375 / 13941.0625 [+4.37%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR33378 has been deleted by mnt. SHA-1: 0db8fad5d8d4e92a2195eb36650f56fdf33d2cd6 |
|
|
Branch CR33378_1 has been deleted by mnt. SHA-1: 758cad3a7320f038b8e3f8004ddb7e19e3d6ff28 |
|
occt: master c36205a0 2023-05-15 07:11:45 Committer: vglukhik Details Diff |
0033378: Configuration - Moving ExpToCas into separate module Moved ExpToCasExe and its DLL to new module - DETools Created new module - DETools to keep tools to DE Changed definition of main of ExpToCasExe to not const parameter FlexLexer.h moved to general location into TKernel |
Affected Issues 0033378 |
|
| mod - adm/cmake/occt_toolkit.cmake | Diff File | ||
| mod - adm/cmake/vardescr.cmake | Diff File | ||
| mod - adm/MODULES | Diff File | ||
| mod - adm/scripts/android_build.bat | Diff File | ||
| mod - adm/scripts/android_custom.bat.template | Diff File | ||
| mod - adm/scripts/cmake_custom.bat.template | Diff File | ||
| mod - adm/scripts/cmake_custom.sh.template | Diff File | ||
| mod - adm/scripts/cmake_gen.bat | Diff File | ||
| mod - adm/scripts/cmake_gen.sh | Diff File | ||
| mod - adm/scripts/ios_build.sh | Diff File | ||
| mod - adm/scripts/ios_custom.sh.template | Diff File | ||
| mod - adm/scripts/macos_build.sh | Diff File | ||
| mod - adm/scripts/macos_custom.sh.template | Diff File | ||
| mod - adm/scripts/mingw_build.bat | Diff File | ||
| mod - adm/scripts/mingw_custom.bat.template | Diff File | ||
| mod - adm/scripts/wasm_build.bat | Diff File | ||
| mod - adm/scripts/wasm_build.sh | Diff File | ||
| mod - adm/scripts/wasm_custom.bat.template | Diff File | ||
| mod - adm/scripts/wasm_custom.sh.template | Diff File | ||
| mod - CMakeLists.txt | Diff File | ||
| mod - src/ExpToCasExe/ExpToCasExe.cxx | Diff File | ||
| rm - src/ExpToCasExe/FlexLexer.h | Diff File | ||
| add - src/FlexLexer/FILES | Diff File | ||
| add - src/FlexLexer/FlexLexer.h | Diff File | ||
| mod - src/OS/DataExchange.tcl | Diff File | ||
| mod - src/StepFile/FILES | Diff File | ||
| rm - src/StepFile/FlexLexer.h | Diff File | ||
| mod - src/TKernel/PACKAGES | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-05-15 09:42 | dpasukhi | New Issue | |
| 2023-05-15 09:42 | dpasukhi | Assigned To | => dpasukhi |
| 2023-05-15 10:10 | dpasukhi | Summary | Configuration - Moving ExpToCas into separete module => Configuration - Moving ExpToCas into separate module |
| 2023-05-15 10:12 | git | Note Added: 0113476 | |
| 2023-05-15 10:32 | git | Note Added: 0113477 | |
| 2023-05-15 10:45 | git | Note Added: 0113478 | |
| 2023-05-15 11:51 | git | Note Added: 0113479 | |
| 2023-05-15 13:14 | git | Note Added: 0113480 | |
| 2023-05-15 23:34 | git | Note Added: 0113487 | |
| 2023-05-16 22:37 | dpasukhi | Assigned To | dpasukhi => ika |
| 2023-05-16 22:37 | dpasukhi | Status | new => resolved |
| 2023-05-16 22:37 | dpasukhi | Steps to Reproduce Updated | |
| 2023-05-16 22:37 | dpasukhi | Note Added: 0113508 | |
| 2023-05-17 17:49 | ika | Assigned To | ika => dpasukhi |
| 2023-05-17 17:49 | ika | Status | resolved => assigned |
| 2023-05-17 17:49 | ika | Note Added: 0113517 | |
| 2023-05-17 17:49 | ika | Note Edited: 0113517 | |
| 2023-05-17 18:10 | git | Note Added: 0113518 | |
| 2023-05-17 18:11 | git | Note Added: 0113519 | |
| 2023-05-17 18:12 | dpasukhi | Assigned To | dpasukhi => ika |
| 2023-05-17 18:12 | dpasukhi | Status | assigned => resolved |
| 2023-05-17 18:12 | dpasukhi | Note Added: 0113520 | |
| 2023-05-18 15:24 | ika | Assigned To | ika => bugmaster |
| 2023-05-18 15:24 | ika | Status | resolved => reviewed |
| 2023-05-18 15:24 | ika | Note Added: 0113527 | |
| 2023-05-22 02:59 | vglukhik | Note Added: 0113545 | |
| 2023-05-22 03:02 | vglukhik | Changeset attached | => occt master c36205a0 |
| 2023-05-22 03:02 | dpasukhi | Assigned To | bugmaster => dpasukhi |
| 2023-05-22 03:02 | dpasukhi | Status | reviewed => verified |
| 2023-05-22 03:02 | dpasukhi | Resolution | open => fixed |
| 2023-05-22 03:17 | git | Note Added: 0113561 | |
| 2023-05-22 03:17 | git | Note Added: 0113562 |
