View Issue Details

IDProjectCategoryView StatusLast Update
0032419Open CASCADEOCCT:Codingpublic2021-12-17 18:41
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version7.6.0 
Target Version7.6.0Fixed in Version7.6.0 
Summary0032419: Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases
DescriptionPorting existing code to 0032337 shows compilations errors.
This is because SelectBasics_SelectingVolumeManager::Overlaps() have been removed without deprecation step.
Steps To ReproduceN/A
TagsNo tags attached.
Test case numberNot required

Relationships

child of 0032337 closedbugmaster Visualization - rename Overlaps() method in selection to more self-describable names 

Activities

git

2021-06-04 12:33

administrator   ~0101601

Branch CR32419 has been created by kgv.

SHA-1: b05e0d4074509e7ad926ff5c303bdce2acb39abc


Detailed log of new commits:

Author: kgv
Date: Fri Jun 4 11:28:49 2021 +0300

    0032419: Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases
    
    Deprecated Overlaps() methods have been moved from subclass SelectMgr_SelectingVolumeManager
    to the base class SelectBasics_SelectingVolumeManager,
    so that they are actually accessible within Select3D_SensitiveEntity::Matches() implementations.
    
    Several methods have been marked as pure virtual in the base interface.
    Second SelectMgr_BaseIntersector::OverlapsPolygon() has been dropped from virtual interface
    as useless (trivially replaceable).

git

2021-06-04 12:38

administrator   ~0101602

Branch CR32419 has been updated forcibly by kgv.

SHA-1: 2965cb4f7778f5cfbee1a02da0254d91ca569444

kgv

2021-06-04 15:59

developer   ~0101608

Please raise the patch
- OCCT: branch CR32419;
- OCC Products: branch CR32419.

http://jenkins-test-occt.nnov.opencascade.com/view/CR32419-CR32419-KGV/

bugmaster

2021-06-05 11:15

administrator   ~0101622

Combination -
OCCT branch : IR-2021-06-04
master SHA - 6a920e02431a1bdfb01d6ff16e1e6a99204d9524
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-06-04 SHA - e72e4fdcde12770fe054f97d3a4a0c82e3c08f11
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17503.060000000427 / 17574.5700000004 [-0.41%]
Products
Total CPU difference: 11532.860000000106 / 11533.700000000124 [-0.01%]
Windows-64-VC14:
OCCT
Total CPU difference: 19219.09375 / 19393.5625 [-0.90%]
Products
Total CPU difference: 12831.25 / 12891.8125 [-0.47%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2021-06-05 11:46

administrator   ~0101642

Branch CR32419 has been deleted by mnt.

SHA-1: 2965cb4f7778f5cfbee1a02da0254d91ca569444

Related Changesets

occt: master 6a920e02

2021-06-04 08:28:49

kgv


Committer: bugmaster Details Diff
0032419: Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases

Deprecated Overlaps() methods have been moved from subclass SelectMgr_SelectingVolumeManager
to the base class SelectBasics_SelectingVolumeManager,
so that they are actually accessible within Select3D_SensitiveEntity::Matches() implementations.

Several methods have been marked as pure virtual in the base interface.
Second SelectMgr_BaseIntersector::OverlapsPolygon() has been dropped from virtual interface
as useless (trivially replaceable).
Affected Issues
0032419
mod - src/MeshVS/MeshVS_SensitivePolyhedron.cxx Diff File
mod - src/Select3D/Select3D_InteriorSensitivePointSet.cxx Diff File
mod - src/Select3D/Select3D_SensitiveCircle.cxx Diff File
mod - src/SelectBasics/FILES Diff File
add - src/SelectBasics/SelectBasics_SelectingVolumeManager.cxx Diff File
mod - src/SelectBasics/SelectBasics_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr_AxisIntersector.cxx Diff File
mod - src/SelectMgr/SelectMgr_AxisIntersector.hxx Diff File
mod - src/SelectMgr/SelectMgr_BaseFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_BaseFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_BaseIntersector.cxx Diff File
mod - src/SelectMgr/SelectMgr_BaseIntersector.hxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.cxx Diff File
mod - src/SelectMgr/SelectMgr_SelectingVolumeManager.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustum.hxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.cxx Diff File
mod - src/SelectMgr/SelectMgr_TriangularFrustumSet.hxx Diff File

occt-products: master e72e4fdc

2021-06-04 12:42:51

kgv


Committer: bugmaster Details Diff
0032419: Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases Affected Issues
0032419
mod - samples/swig/TKV3d.i Diff File

Issue History

Date Modified Username Field Change
2021-06-04 10:56 kgv New Issue
2021-06-04 10:56 kgv Assigned To => kgv
2021-06-04 10:58 kgv Relationship added child of 0032337
2021-06-04 12:33 git Note Added: 0101601
2021-06-04 12:38 git Note Added: 0101602
2021-06-04 15:59 kgv Note Added: 0101608
2021-06-04 15:59 kgv Assigned To kgv => bugmaster
2021-06-04 15:59 kgv Status new => resolved
2021-06-04 15:59 kgv Status resolved => reviewed
2021-06-05 11:15 bugmaster Note Added: 0101622
2021-06-05 11:15 bugmaster Status reviewed => tested
2021-06-05 11:18 bugmaster Test case number => Not required
2021-06-05 11:21 bugmaster Changeset attached => occt master 6a920e02
2021-06-05 11:21 bugmaster Status tested => verified
2021-06-05 11:21 bugmaster Resolution open => fixed
2021-06-05 11:46 git Note Added: 0101642
2021-12-17 18:41 bugmaster Changeset attached => occt-products master e72e4fdc