View Issue Details

IDProjectCategoryView StatusLast Update
0031465CommunityOCCT:Data Exchangepublic2020-12-02 17:12
Reporterkgv Assigned Tobugmaster  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
Product Version7.4.0 
Target Version7.5.0Fixed in Version7.5.0 
Summary0031465: Data Exchange, RWObj_Reader - skip duplicating smooth groups
DescriptionSome OBJ files contains duplicated information about smooth groups ("s 1" statements) of enormous amount (for each mesh element). This is redundant information increasing file size, but apart from this, RWObj_Reader emits new Face for each smooth group statement, leading to enormous amount of Faces and no smoothing.
TagsNo tags attached.
Test case numberde_mesh/obj_read/smooth

Attached Files

  • E-Bus - 4H.7z (878,157 bytes)
  • P Turboprop - 4H.7z (69,756 bytes)
  • cadass_turboprop_KO.png (92,502 bytes)
  • cadass_turboprop_faces_KO.png (110,611 bytes)
  • sphere_KO.png (11,531 bytes)
  • sphere_OK.png (14,109 bytes)

Activities

kgv

2020-03-26 11:46

developer  

E-Bus - 4H.7z (878,157 bytes)

kgv

2020-03-26 11:46

developer  

P Turboprop - 4H.7z (69,756 bytes)

kgv

2020-03-26 11:49

developer  

cadass_turboprop_KO.png (92,502 bytes)

kgv

2020-03-26 11:51

developer  

cadass_turboprop_faces_KO.png (110,611 bytes)

kgv

2020-03-26 13:00

developer  

sphere_KO.png (11,531 bytes)

kgv

2020-03-26 13:41

developer  

sphere_OK.png (14,109 bytes)

git

2020-03-26 13:47

administrator   ~0091265

Branch CR31465 has been created by kgv.

SHA-1: 345aeeed43997a042b30b7ff3553be5683e6e5c3


Detailed log of new commits:

Author: kgv
Date: Thu Mar 26 13:48:09 2020 +0300

    0031465: Data Exchange, RWObj_Reader - skip duplicating smooth groups
    
    RWObj_Reader::pushSmoothGroup() now ignores smooth groups statements pointing to the same group.

kgv

2020-03-26 14:49

developer   ~0091271

Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31465-master-KGV

kgv

2020-03-26 21:47

developer   ~0091286

Last edited: 2020-03-26 21:47

Please raise patch in OCCT branch CR31465.

bugmaster

2020-03-27 14:57

administrator   ~0091306

Combination -
OCCT branch : WEEK-13
master SHA - 64943a5187fa485536cd2dd1dd4d51b13d189b89
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : WEEK-13 SHA - f10b867b449ebfa55e0a3c8cb276ae511f9cf7f2
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16868.620000000134 / 16846.320000000138 [+0.13%]
Products
Total CPU difference: 11317.180000000084 / 11306.210000000074 [+0.10%]
Windows-64-VC14:
OCCT
Total CPU difference: 18288.046875 / 18268.796875 [+0.11%]
Products
Total CPU difference: 13120.859375 / 13110.609375 [+0.08%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2020-03-28 13:46

administrator   ~0091319

Branch CR31465 has been deleted by inv.

SHA-1: 345aeeed43997a042b30b7ff3553be5683e6e5c3

Related Changesets

occt: master 85b14758

2020-03-26 10:48:09

kgv


Committer: bugmaster Details Diff
0031465: Data Exchange, RWObj_Reader - skip duplicating smooth groups

RWObj_Reader::pushSmoothGroup() now ignores smooth groups statements pointing to the same group.
Affected Issues
0031465
mod - src/RWObj/RWObj_Reader.cxx Diff File
add - tests/de_mesh/obj_read/smooth Diff File

Issue History

Date Modified Username Field Change
2020-03-26 11:44 kgv New Issue
2020-03-26 11:44 kgv Assigned To => kgv
2020-03-26 11:46 kgv File Added: E-Bus - 4H.7z
2020-03-26 11:46 kgv File Added: P Turboprop - 4H.7z
2020-03-26 11:49 kgv File Added: cadass_turboprop_KO.png
2020-03-26 11:51 kgv File Added: cadass_turboprop_faces_KO.png
2020-03-26 13:00 kgv File Added: sphere_KO.png
2020-03-26 13:41 kgv File Added: sphere_OK.png
2020-03-26 13:47 git Note Added: 0091265
2020-03-26 14:49 kgv Note Added: 0091271
2020-03-26 14:49 kgv Assigned To kgv => osa
2020-03-26 14:49 kgv Status new => resolved
2020-03-26 21:47 kgv Note Added: 0091286
2020-03-26 21:47 kgv Assigned To osa => bugmaster
2020-03-26 21:47 kgv Severity minor => trivial
2020-03-26 21:47 kgv Status resolved => reviewed
2020-03-26 21:47 kgv Note Edited: 0091286
2020-03-27 14:57 bugmaster Note Added: 0091306
2020-03-27 14:57 bugmaster Status reviewed => tested
2020-03-27 15:02 bugmaster Test case number => de_mesh/obj_read/smooth
2020-03-28 13:36 bugmaster Changeset attached => occt master 85b14758
2020-03-28 13:36 bugmaster Status tested => verified
2020-03-28 13:36 bugmaster Resolution open => fixed
2020-03-28 13:46 git Note Added: 0091319
2020-12-02 16:43 emo Fixed in Version => 7.5.0
2020-12-02 17:12 emo Status verified => closed