View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0030687 | Open CASCADE | OCCT:Visualization | public | 2019-05-01 14:12 | 2021-03-19 13:58 |
| Reporter | kgv | Assigned To | kgv | ||
| Priority | normal | Severity | integration request | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.4.0 | Fixed in Version | 7.4.0 | ||
| Summary | 0030687: Visualization - remove redundant interfaces SelectBasics_EntityOwner and SelectBasics_SensitiveEntity | ||||
| Description | SelectBasics_EntityOwner is a redundant and incomplete interface class having only single implementation - SelectMgr_EntityOwner. Current design relies on DownCast() to SelectMgr_EntityOwner everywhere, hence eliminating redundant base class will make code more straightforward. | ||||
| Steps To Reproduce | N/A | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR30687 has been created by kgv. SHA-1: 78977a273341be2143a53fcdb1e98335cc053959 Detailed log of new commits: Author: kgv Date: Wed May 1 14:14:28 2019 +0300 0030687: Visualization - remove redundant interface SelectBasics_EntityOwner SelectBasics_EntityOwner has been merged into SelectMgr_EntityOwner. Unused property SelectMgr_EntityOwner::ResetLocation() has been removed. SelectBasics package has been moved from TKService to TKV3d. |
|
|
Branch CR30687 has been updated forcibly by kgv. SHA-1: 01342afcc809bd937e6bf0ab8d6528fc04360f32 |
|
|
Branch CR30687 has been updated by kgv. SHA-1: d436ecd29778840226a4fb3c093b8beb719e7471 Detailed log of new commits: Author: kgv Date: Wed May 1 14:58:07 2019 +0300 SelectBasics_SensitiveEntity has been merged into Select3D_SensitiveEntity. |
|
|
Branch CR30687_1 has been created by kgv. SHA-1: e4d8a703fe9a454f32ceae65bd958ac250152e6d Detailed log of new commits: Author: kgv Date: Wed May 1 14:14:28 2019 +0300 0030687: Visualization - remove redundant interfaces SelectBasics_EntityOwner and SelectBasics_SensitiveEntity SelectBasics_EntityOwner has been merged into SelectMgr_EntityOwner. Unused property SelectMgr_EntityOwner::ResetLocation() has been removed. SelectBasics package has been moved from TKService to TKV3d. SelectBasics_SensitiveEntity has been merged into Select3D_SensitiveEntity. |
|
|
Branch CR30687_1 has been updated forcibly by kgv. SHA-1: f337e6589e0d27b39ed8c4c4ddb5e74362c82e6b |
|
|
Patch is ready for review. http://jenkins-test-12.nnov.opencascade.com:8080/view/CR30687_1-CR30687_1-KGV |
|
|
Branch CR30687_1 in occt and occt-products reviewed without remarks. |
|
|
Combination - OCCT branch : CR30687_1 master SHA - f337e6589e0d27b39ed8c4c4ddb5e74362c82e6b d67d4b811012eef8913d3c535c29654d0acf3c4c Products branch : CR30687_1 SHA - d5212caf37121bb7a36298ead5e0d5fd3f6b5b3e was compiled on Linux, MacOS and Windows platforms and tested in optimize mode. Number of compiler warnings: No new/fixed warnings Regressions/Differences/Improvements: No regressions/differences CPU differences: Debian80-64: OCCT Total CPU difference: 16326.55999999998 / 16286.290000000015 [+0.25%] Products Total CPU difference: 10536.410000000033 / 10492.700000000066 [+0.42%] Windows-64-VC14: OCCT Total CPU difference: 17628.296875 / 17645.203125 [-0.10%] Products Total CPU difference: 12086.5 / 12107.4375 [-0.17%] Image differences : No differences that require special attention Memory differences : No differences that require special attention |
|
|
Branch CR30687_2 has been created by kgv. SHA-1: 0ef04197f700fdf9bb02c1d156c2a96753f4b838 Detailed log of new commits: Author: kgv Date: Tue May 21 19:42:15 2019 +0300 0030687: Visualization - remove redundant interfaces SelectBasics_EntityOwner and SelectBasics_SensitiveEntity SelectBasics_EntityOwner has been merged into SelectMgr_EntityOwner. Unused property SelectMgr_EntityOwner::ResetLocation() has been removed. SelectBasics package has been moved from TKService to TKV3d. SelectBasics_SensitiveEntity has been merged into Select3D_SensitiveEntity. |
|
|
Branch CR30687_2 has been deleted by inv. SHA-1: 0ef04197f700fdf9bb02c1d156c2a96753f4b838 |
|
|
Branch CR30687_1 has been deleted by inv. SHA-1: f337e6589e0d27b39ed8c4c4ddb5e74362c82e6b |
|
|
Branch CR30687 has been deleted by inv. SHA-1: d436ecd29778840226a4fb3c093b8beb719e7471 |
|
occt: master 0ef04197 2019-05-21 16:42:15 Details Diff |
0030687: Visualization - remove redundant interfaces SelectBasics_EntityOwner and SelectBasics_SensitiveEntity SelectBasics_EntityOwner has been merged into SelectMgr_EntityOwner. Unused property SelectMgr_EntityOwner::ResetLocation() has been removed. SelectBasics package has been moved from TKService to TKV3d. SelectBasics_SensitiveEntity has been merged into Select3D_SensitiveEntity. |
Affected Issues 0030687 |
|
| mod - dox/dev_guides/upgrade/upgrade.md | Diff File | ||
| mod - dox/user_guides/visualization/visualization.md | Diff File | ||
| mod - samples/mfc/standard/03_Viewer2d/src/StdAfx.h | Diff File | ||
| mod - src/AIS/AIS_Axis.cxx | Diff File | ||
| mod - src/AIS/AIS_ColoredShape.cxx | Diff File | ||
| mod - src/AIS/AIS_ConnectedInteractive.cxx | Diff File | ||
| mod - src/AIS/AIS_InteractiveContext_1.cxx | Diff File | ||
| mod - src/AIS/AIS_Manipulator.cxx | Diff File | ||
| mod - src/AIS/AIS_Plane.cxx | Diff File | ||
| mod - src/AIS/AIS_Point.cxx | Diff File | ||
| mod - src/AIS/AIS_Trihedron.cxx | Diff File | ||
| mod - src/AIS/AIS_Trihedron.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_CommonSensitiveEntity.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_CommonSensitiveEntity.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_DummySensitiveEntity.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_DummySensitiveEntity.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_Mesh.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_MeshEntityOwner.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_MeshOwner.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_PrsBuilder.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_PrsBuilder.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveFace.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveFace.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveMesh.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveMesh.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitivePolyhedron.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitivePolyhedron.hxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveQuad.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveSegment.cxx | Diff File | ||
| mod - src/MeshVS/MeshVS_SensitiveSegment.hxx | Diff File | ||
| mod - src/Select3D/Select3D_InteriorSensitivePointSet.cxx | Diff File | ||
| mod - src/Select3D/Select3D_InteriorSensitivePointSet.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveBox.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveBox.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveCircle.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveCircle.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveCurve.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveCurve.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveEntity.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveEntity.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveFace.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveFace.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveGroup.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveGroup.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePoint.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePoint.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePoly.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePoly.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePrimitiveArray.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitivePrimitiveArray.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveSegment.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveSegment.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveSet.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveSet.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveTriangle.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveTriangle.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveTriangulation.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveTriangulation.hxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveWire.cxx | Diff File | ||
| mod - src/Select3D/Select3D_SensitiveWire.hxx | Diff File | ||
| mod - src/SelectBasics/FILES | Diff File | ||
| rm - src/SelectBasics/SelectBasics.cxx | Diff File | ||
| mod - src/SelectBasics/SelectBasics.hxx | Diff File | ||
| rm - src/SelectBasics/SelectBasics_EntityOwner.cxx | Diff File | ||
| mod - src/SelectBasics/SelectBasics_EntityOwner.hxx | Diff File | ||
| mod - src/SelectBasics/SelectBasics_PickResult.hxx | Diff File | ||
| rm - src/SelectBasics/SelectBasics_SensitiveEntity.cxx | Diff File | ||
| mod - src/SelectBasics/SelectBasics_SensitiveEntity.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_EntityOwner.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_EntityOwner.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_IndexedDataMapOfOwnerCriterion.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SelectableObject.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_Selection.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_Selection.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SensitiveEntity.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SensitiveEntity.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SensitiveEntitySet.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_SortCriterion.hxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_ViewerSelector.cxx | Diff File | ||
| mod - src/SelectMgr/SelectMgr_ViewerSelector.hxx | Diff File | ||
| mod - src/StdSelect/StdSelect_BRepOwner.cxx | Diff File | ||
| mod - src/StdSelect/StdSelect_BRepOwner.hxx | Diff File | ||
| mod - src/StdSelect/StdSelect_BRepSelectionTool.cxx | Diff File | ||
| mod - src/StdSelect/StdSelect_IndexedDataMapOfOwnerPrs.hxx | Diff File | ||
| mod - src/StdSelect/StdSelect_ViewerSelector3d.cxx | Diff File | ||
| mod - src/TKService/PACKAGES | Diff File | ||
| mod - src/TKV3d/PACKAGES | Diff File | ||
| mod - src/ViewerTest/ViewerTest.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemContext.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemEntityOwner.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemEntityOwner.hxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemPresentableObject.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemSelection.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemSensitiveEntity.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ItemSensitiveEntity.hxx | Diff File | ||
| mod - tools/VInspector/VInspector_Tools.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_Tools.hxx | Diff File | ||
| mod - tools/VInspector/VInspector_ViewModel.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_ViewModel.hxx | Diff File | ||
| mod - tools/VInspector/VInspector_Window.cxx | Diff File | ||
| mod - tools/VInspector/VInspector_Window.hxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-05-01 14:12 | kgv | New Issue | |
| 2019-05-01 14:12 | kgv | Assigned To | => kgv |
| 2019-05-01 14:12 | kgv | Relationship added | related to 0030675 |
| 2019-05-01 14:21 | git | Note Added: 0084089 | |
| 2019-05-01 14:30 | git | Note Added: 0084091 | |
| 2019-05-01 15:04 | git | Note Added: 0084092 | |
| 2019-05-01 15:05 | kgv | Summary | Visualization - remove redundant interface SelectBasics_EntityOwner => Visualization - remove redundant interfaces SelectBasics_EntityOwner and SelectBasics_SensitiveEntity |
| 2019-05-01 15:06 | git | Note Added: 0084093 | |
| 2019-05-01 15:49 | git | Note Added: 0084095 | |
| 2019-05-01 23:08 | kgv | Note Added: 0084099 | |
| 2019-05-01 23:08 | kgv | Assigned To | kgv => san |
| 2019-05-01 23:08 | kgv | Status | new => resolved |
| 2019-05-21 18:03 |
|
Note Added: 0084516 | |
| 2019-05-21 18:03 |
|
Assigned To | san => bugmaster |
| 2019-05-21 18:03 |
|
Status | resolved => reviewed |
| 2019-05-21 19:17 | bugmaster | Test case number | => Not required |
| 2019-05-21 19:19 | bugmaster | Note Added: 0084523 | |
| 2019-05-21 19:19 | bugmaster | Status | reviewed => tested |
| 2019-05-21 19:43 | git | Note Added: 0084524 | |
| 2019-05-25 19:58 | kgv | Changeset attached | => occt master 0ef04197 |
| 2019-05-25 19:58 | kgv | Assigned To | bugmaster => kgv |
| 2019-05-25 19:58 | kgv | Status | tested => verified |
| 2019-05-25 19:58 | kgv | Resolution | open => fixed |
| 2019-05-26 10:48 | git | Note Added: 0084628 | |
| 2019-05-26 10:49 | git | Note Added: 0084638 | |
| 2019-05-26 10:49 | git | Note Added: 0084639 | |
| 2021-03-19 13:58 | kgv | Relationship added | parent of 0032230 |
