View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0027991Open CASCADEOCCT:Modeling Algorithmspublic2016-10-22 18:232018-04-24 11:52
Reporterkgv Assigned Toapv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2015 
Product Version6.3.1 
Target Version7.1.0Fixed in Version7.1.0 
Summary0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
DescriptionIt is suggested that BRepGProp_Face will handle faces without geometric surface smoothly - at least without a crash.
Steps To Reproduce
pload MODELING VISUALIZATION
restore [locate_data_file bug27821_nullsurf.brep] s
sprops s


Result:
An exception was caught 0000000005835120 : OSD_Exception_ACCESS_VIOLATION: ACCESS VIOLATION at address 0x0000000000000000 during 'READ' operation
** Exception ** 0000000005835120 : OSD_Exception_ACCESS_VIOLATION: ACCESS VIOLATION at address 0x0000000000000000 during 'READ' operation
TagsNo tags attached.
Test case numberbugs vis bug27821

Relationships

related to 0027821 closedbugmaster Visualization, AIS_Shape - add NULL checks for displaying TopoDS_Face with NULL surface 
related to 0027992 closedapn Modeling Algorithms - Extrema_ExtPS crashes on face without geometric surface 
related to 0028125 newmsv Modeling Algorithms - support of BRep shapes based on tessellated geometry 
related to 0029524 closedbugmaster Modeling Algorithms - access violation in HLRBRep_PolyAlgo while computing HLR for triangulation-only surface 

Activities

git

2016-10-22 18:38

administrator   ~0058981

Branch CR27991 has been created by kgv.

SHA-1: 6630a31f52ff8ce21ad3be148b86515769d4a255


Detailed log of new commits:

Author: kgv
Date: Sat Oct 22 18:37:51 2016 +0300

    0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface

kgv

2016-10-22 18:43

developer   ~0058982

Last edited: 2016-10-22 18:43

 The workaround fixing the crash has been pushed to the branch.
Note that the shape contains triangulation - thus some surface properties like area can be actually computed from it.

git

2016-10-22 19:24

administrator   ~0058983

Branch CR27991 has been updated forcibly by kgv.

SHA-1: 738f2ecf6316d7947d039d78351b76d3d578edaa

msv

2016-10-24 10:17

developer   ~0058991

No remarks to implementation. But please describe in commit message what you have done, because you fixed two other places not connected directly with gprops calculation.

msv

2016-10-24 10:17

developer   ~0058992

Also, create a test case.

git

2016-10-24 16:11

administrator   ~0059030

Branch CR27991 has been updated forcibly by kgv.

SHA-1: 6cfe5e6412f18fa4d2ac6c2b326f526a8007f044

kgv

2016-10-24 16:12

developer   ~0059031

Commit message has been updated.
Test case bugs/vis/bug27821 has been extended to check this issue as well.

git

2016-10-24 18:24

administrator   ~0059040

Branch CR27991 has been updated forcibly by msv.

SHA-1: 9d9e9239aa2ec6d858bbca4d415102ac9c0412ad

msv

2016-10-24 18:25

developer   ~0059041

Commit message has been updated.

msv

2016-10-24 18:25

developer   ~0059042

Reviewed.

apv

2016-10-26 14:11

tester   ~0059165

Last edited: 2016-10-26 14:11

 Dear BugMaster,

Branch CR27991 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 9d9e9239aa2ec6d858bbca4d415102ac9c0412ad

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1167

Regressions/Differences:
http://occt-tests/CR27991-master-OCCT/Debian70-64/summary.html
http://occt-tests/CR27991-master-OCCT/Windows-64-VC10/summary.html
prj base C5, C6

Testing cases:
bugs vis bug27821 - OK
http://occt-tests/CR27991-master-OCCT/Debian70-64/bugs/vis/bug27821.html
http://occt-tests/CR27991-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html

Testing on Linux:
Total MEMORY difference: 89935820 / 90328255 [-0.43%]
Total CPU difference: 19489.399999999965 / 19231.589999999847 [+1.34%]

Testing on Windows:
Total MEMORY difference: 57288337 / 57220230 [+0.12%]
Total CPU difference: 17906.434384098717 / 18211.026336598778 [-1.67%]

There is difference in images found by testdiff:
http://occt-tests/CR27991-master-OCCT/Debian70-64/diff-Debian70-64.html
http://occt-tests/CR27991-master-OCCT/Windows-64-VC10/diff-Windows-64-VC10-image.html
bugs modalg_2 bug472_3

apv

2016-10-26 14:13

tester   ~0059166

Dear Kirill,

Branch CR27991 has been rejected due to:
- regressions/differences/improvements
- differences in images

git

2016-10-26 22:03

administrator   ~0059217

Branch CR27991 has been updated by kgv.

SHA-1: 3e80a0b142be8ce119685d9df71f437b9d71ba40


Detailed log of new commits:

Author: kgv
Date: Wed Oct 26 22:03:42 2016 +0300

    fix regression

git

2016-10-26 22:07

administrator   ~0059218

Branch CR27991_1 has been created by kgv.

SHA-1: 85103e140443d6adbe3e1d7ace47ad0f7d74fe30


Detailed log of new commits:

Author: kgv
Date: Sat Oct 22 18:37:51 2016 +0300

    0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
    
    BRepGProps now ignores faces without geometric surface to avoid access violation.
    BRepExtrema_DistShapeShape::DistanceMapMap() now skips comparison between void bounding boxes.
    BRepBndLib::Add() now ignores useTriangulation flag for faces without geometric surfaces, and uses triangulation if any for updating of the box.

kgv

2016-10-26 22:07

developer   ~0059219

Please check updated patch.

git

2016-10-28 17:27

administrator   ~0059367

Branch CR27991_1 has been updated forcibly by apv.

SHA-1: 4d19a2c5e73415f81c1e3cae34bdd0fe1ddd0b66

apv

2016-10-28 17:27

tester   ~0059368

Branch CR27991_1 has been rebased on the current master

apv

2016-10-31 15:32

tester   ~0059638

Last edited: 2016-10-31 15:33

 Dear BugMaster,

Branch CR27991_1 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested.
SHA-1: 4d19a2c5e73415f81c1e3cae34bdd0fe1ddd0b66

Number of compiler warnings:
occt component:
   Linux: 0 (0 on master)
   Windows: 0 (0 on master)
   MasOS: 0 (0 on master)
products component:
   Linux: 63
   Windows: 0
   MacOS: 1149

Regressions/Differences:
Not detected

Testing cases:
bugs vis bug27821 - OK
http://occt-tests/CR27991_1-master-OCCT/Debian70-64/bugs/vis/bug27821.html
http://occt-tests/CR27991_1-master-OCCT/Windows-64-VC10/bugs/vis/bug27821.html

Testing on Linux:
Total MEMORY difference: 91250103 / 90744466 [+0.56%]
Total CPU difference: 19325.789999999834 / 19313.189999999897 [+0.07%]

Testing on Windows:
Total MEMORY difference: 57304054 / 57321116 [-0.03%]
Total CPU difference: 17981.970068298648 / 18220.18359529866 [-1.31%]

git

2016-12-07 11:25

administrator   ~0061216

Branch CR27991 has been deleted by kgv.

SHA-1: 3e80a0b142be8ce119685d9df71f437b9d71ba40

git

2016-12-07 11:25

administrator   ~0061217

Branch CR27991_1 has been deleted by kgv.

SHA-1: 4d19a2c5e73415f81c1e3cae34bdd0fe1ddd0b66

Related Changesets

occt: master 4d19a2c5

2016-10-22 15:37:51

kgv


Committer: apv Details Diff		 0027991: Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface

BRepGProps now ignores faces without geometric surface to avoid access violation.
BRepExtrema_DistShapeShape::DistanceMapMap() now skips comparison between void bounding boxes.
BRepBndLib::Add() now ignores useTriangulation flag for faces without geometric surfaces, and uses triangulation if any for updating of the box.		 Affected Issues
0027991
mod - src/BRepBndLib/BRepBndLib.cxx Diff File
mod - src/BRepExtrema/BRepExtrema_DistShapeShape.cxx Diff File
mod - src/BRepGProp/BRepGProp.cxx Diff File
mod - tests/bugs/vis/bug27821 Diff File

Issue History

Date Modified Username Field Change
2016-10-22 18:23 kgv New Issue
2016-10-22 18:23 kgv Assigned To => msv
2016-10-22 18:23 kgv Relationship added related to 0027821
2016-10-22 18:27 kgv Steps to Reproduce Updated
2016-10-22 18:37 kgv Summary Modeling Algorithms - BRepGProp_Face is crashing on face without geometric surface => Modeling Algorithms - BRepGProp_Face crashes on face without geometric surface
2016-10-22 18:38 git Note Added: 0058981
2016-10-22 18:41 kgv Product Version 7.0.0 => 6.3.1
2016-10-22 18:43 kgv Note Added: 0058982
2016-10-22 18:43 kgv Status new => resolved
2016-10-22 18:43 kgv Note Edited: 0058982
2016-10-22 19:24 git Note Added: 0058983
2016-10-22 19:25 kgv Relationship added related to 0027992
2016-10-24 10:17 msv Note Added: 0058991
2016-10-24 10:17 msv Assigned To msv => kgv
2016-10-24 10:17 msv Status resolved => assigned
2016-10-24 10:17 msv Note Added: 0058992
2016-10-24 16:11 git Note Added: 0059030
2016-10-24 16:12 kgv Note Added: 0059031
2016-10-24 16:12 kgv Assigned To kgv => msv
2016-10-24 16:12 kgv Status assigned => resolved
2016-10-24 18:24 git Note Added: 0059040
2016-10-24 18:25 msv Note Added: 0059041
2016-10-24 18:25 msv Note Added: 0059042
2016-10-24 18:25 msv Assigned To msv => bugmaster
2016-10-24 18:25 msv Status resolved => reviewed
2016-10-24 18:56 apv Assigned To bugmaster => apv
2016-10-26 13:37 apv Test case number => bugs vis bug27821
2016-10-26 14:11 apv Note Added: 0059165
2016-10-26 14:11 apv Assigned To apv => kgv
2016-10-26 14:11 apv Status reviewed => assigned
2016-10-26 14:11 apv Note Edited: 0059165
2016-10-26 14:13 apv Note Added: 0059166
2016-10-26 22:03 git Note Added: 0059217
2016-10-26 22:07 git Note Added: 0059218
2016-10-26 22:07 kgv Note Added: 0059219
2016-10-26 22:07 kgv Assigned To kgv => bugmaster
2016-10-26 22:07 kgv Status assigned => resolved
2016-10-26 22:08 kgv Status resolved => reviewed
2016-10-27 09:55 apv Assigned To bugmaster => apv
2016-10-28 17:27 git Note Added: 0059367
2016-10-28 17:27 apv Note Added: 0059368
2016-10-31 15:32 apv Note Added: 0059638
2016-10-31 15:32 apv Assigned To apv => bugmaster
2016-10-31 15:32 apv Status reviewed => tested
2016-10-31 15:33 apv Note Edited: 0059638
2016-11-03 17:10 apv Changeset attached => occt master 4d19a2c5
2016-11-03 17:10 apv Assigned To bugmaster => apv
2016-11-03 17:10 apv Status tested => verified
2016-11-03 17:10 apv Resolution open => fixed
2016-11-17 17:22 abv Relationship added related to 0028125
2016-12-07 11:25 git Note Added: 0061216
2016-12-07 11:25 git Note Added: 0061217
2016-12-09 16:30 aiv Status verified => closed
2016-12-09 16:39 aiv Fixed in Version => 7.1.0
2018-04-24 11:52 kgv Relationship added related to 0029524