0024547: Convertation of the generic classes to the non-generic (math)

ID	Project	Category	View Status	Date Submitted	Last Update

0024547	Open CASCADE	OCCT:Coding	public	2014-01-21 12:15	2014-11-11 12:51

Reporter	~~dln~~	Assigned To	apn
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Platform	x64	OS	Windows
Product Version	6.7.0
Target Version	6.8.0	Fixed in Version	6.8.0

Summary	0024547: Convertation of the generic classes to the non-generic (math)
Description	In the package "math": - class "math_DoubleTab" was converted to the non-generic class. Some changes were made in the class "math_Matrix". - class "math_SingleTab" was converted to the non-generic template class. And classes "math_Vector" and "math_IntegerVector" converted to the non-cdl, because they use template class "math_SingleTab"
Tags	No tags attached.

Test case number	Not needed

~~dln~~ 2014-01-21 14:10 developer ~0027575	Changes are ready for review in CR24547 branch.

~~abv~~ 2014-01-22 15:59 manager ~0027604	Igor, please review the fix; from my side I have no remarks

~~ifv~~ 2014-01-22 17:19 developer ~0027610	Seems to be Ok Small remark: in my opinion, it is possible to remove math_Matrix from friends of math_IntegerVector because it is never used. Natural frieds are math_Matrix and math_Vector, it is used in some methods of math_Matrix and math_Vector.

~~abv~~ 2014-01-22 17:42 manager ~0027612	I have pushed one more commit removing mentioned friend statement.

~~mkv~~ 2014-01-23 15:51 tester ~0027630	Dear BugMaster, Branch CR24547 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: a0773e04b59aa18a53256631dc829bcdbcbb50fe Number of compiler warnings: occt component : Linux: 48 (48 on master) Windows: 1 (1 on master) products component : Linux: 12 (12 on master) Windows: 2 (2 on master) Regressions/Differences: http://occt-tests/CR24547-master-occt/Debian60-64/summary.html http://occt-tests/CR24547-master-occt/Windows-32-VC9/summary.html Testing cases: Not needed

~~dln~~ 2014-02-06 11:02 developer ~0027798	Branch CR24547 was updated, check it please.

kgv 2014-02-06 12:04 developer ~0027800	Dear dln, +template<class T> class math_SingleTab +{ +public: + + DEFINE_STANDARD_ALLOC + + Standard_EXPORT math_SingleTab(const Standard_Integer LowerIndex, const Standard_Integer UpperIndex) : + Addr(Buf), + isAllocated(UpperIndex - LowerIndex + 1 > aLengthOfBuf), could you please remove Standard_EXPORT from all methods of template classes?

~~dln~~ 2014-02-06 12:16 developer ~0027801 Last edited: 2014-02-06 12:31	Dear kgv, Ok, i'll correct it

~~dln~~ 2014-02-06 12:36 developer ~0027802	Corrected. CR24547

~~abv~~ 2014-02-07 12:02 manager ~0027811	Dmitry, please correct comments in the header files to be suitable for Doxygen generation: - remove angle brackets (text within <> is considered as HTML tag by Doxygen) - add @code ... @endcode around sample code blocks (see http://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmdcode) - add empty lines between the method declaration and comment to the next one Then please verify the result by running Doxygen (command wgendoc in WOK) and checking the resulting HTML documentation

~~dln~~ 2014-02-07 18:54 developer ~0027818	Dear Andrey, Check it please. (CR24547)

~~abv~~ 2014-02-08 17:33 manager ~0027821	No remarks, please test

~~mkv~~ 2014-02-10 17:39 tester ~0027833	Dear BugMaster, Branch CR24547 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: e275e53df0b56cbb019baac530ef087fcb90d9ac Number of compiler warnings: occt component : Linux: 40 (40 on master) Windows: 0 (0 on master) products component : Linux: 12 (12 on master) Windows: 2 (2 on master) Regressions/Differences: No regressions/differences Testing cases: Not needed Testing on Linux: Total MEMORY difference: 381611520 / 381831144 Total CPU difference: 42478.560000000005 / 42213.76 Testing on Windows: Total MEMORY difference: 430537788 / 431123492 Total CPU difference: 32528.59375 / 34130.65625 There are not differences in images found by testdiff.

occt: master 3b010a74 2014-01-21 08:15:53 ~~dln~~ Committer: apn Details Diff	0024547: Convertation of the generic classes to the non-generic (math). - class "math_DoubleTab" was converted to the non-generic class. Some changes were made in the class "math_Matrix". And some stylish changes were made. - class "math_SingleTab" was converted to the non-generic template class. And classes "math_Vector" and "math_IntegerVector" converted to the non-cdl, because they use template class "math_Vector". Some stylish changes were made.	Affected Issues 0024547
	mod - src/math/FILES	Diff File
	mod - src/math/math.cdl	Diff File
	mod - src/math/math_DoubleTab.cdl	Diff File
	mod - src/math/math_DoubleTab.lxx	Diff File
	rm - src/math/math_IntegerVector.cdl	Diff File
	mod - src/math/math_IntegerVector.cxx	Diff File
	add - src/math/math_IntegerVector.hxx	Diff File
	rm - src/math/math_IntegerVector.lxx	Diff File
	mod - src/math/math_Matrix.cdl	Diff File
	mod - src/math/math_Matrix.cxx	Diff File
	rm - src/math/math_SingleTab.cdl	Diff File
	rm - src/math/math_SingleTab.gxx	Diff File
	add - src/math/math_SingleTab.hxx	Diff File
	rm - src/math/math_SingleTab.lxx	Diff File
	rm - src/math/math_Vector.cdl	Diff File
	mod - src/math/math_Vector.cxx	Diff File
	add - src/math/math_Vector.hxx	Diff File
	rm - src/math/math_Vector.lxx	Diff File

Date Modified	Username	Field	Change
2014-01-21 12:15	~~dln~~	New Issue
2014-01-21 12:15	~~dln~~	Assigned To	=> abv
2014-01-21 14:05	~~dln~~	Description Updated
2014-01-21 14:09	~~dln~~	Relationship added	child of 0024487
2014-01-21 14:10	~~dln~~	Note Added: 0027575
2014-01-21 14:57	~~dln~~	Status	new => resolved
2014-01-22 08:21	~~dln~~	Description Updated
2014-01-22 15:59	~~abv~~	Assigned To	abv => ifv
2014-01-22 15:59	~~abv~~	Note Added: 0027604
2014-01-22 17:19	~~ifv~~	Note Added: 0027610
2014-01-22 17:19	~~ifv~~	Status	resolved => reviewed
2014-01-22 17:42	~~abv~~	Note Added: 0027612
2014-01-22 17:42	~~abv~~	Assigned To	ifv => bugmaster
2014-01-23 07:08	~~mkv~~	Assigned To	bugmaster => mkv
2014-01-23 15:51	~~mkv~~	Note Added: 0027630
2014-01-23 15:51	~~mkv~~	Test case number	=> Not needed
2014-01-23 15:51	~~mkv~~	Assigned To	mkv => dln
2014-01-23 15:51	~~mkv~~	Status	reviewed => assigned
2014-02-06 11:02	~~dln~~	Note Added: 0027798
2014-02-06 11:02	~~dln~~	Assigned To	dln => abv
2014-02-06 11:02	~~dln~~	Status	assigned => resolved
2014-02-06 12:04	kgv	Note Added: 0027800
2014-02-06 12:04	kgv	Assigned To	abv => dln
2014-02-06 12:04	kgv	Status	resolved => assigned
2014-02-06 12:16	~~dln~~	Note Added: 0027801
2014-02-06 12:31	~~dln~~	Note Edited: 0027801
2014-02-06 12:36	~~dln~~	Note Added: 0027802
2014-02-06 12:36	~~dln~~	Assigned To	dln => abv
2014-02-06 12:36	~~dln~~	Status	assigned => resolved
2014-02-07 12:02	~~abv~~	Note Added: 0027811
2014-02-07 12:02	~~abv~~	Assigned To	abv => dln
2014-02-07 12:02	~~abv~~	Status	resolved => assigned
2014-02-07 18:54	~~dln~~	Note Added: 0027818
2014-02-07 18:54	~~dln~~	Assigned To	dln => abv
2014-02-07 18:54	~~dln~~	Status	assigned => resolved
2014-02-08 17:33	~~abv~~	Note Added: 0027821
2014-02-08 17:33	~~abv~~	Assigned To	abv => bugmaster
2014-02-08 17:33	~~abv~~	Status	resolved => reviewed
2014-02-10 13:01	~~mkv~~	Assigned To	bugmaster => mkv
2014-02-10 17:39	~~mkv~~	Note Added: 0027833
2014-02-10 17:39	~~mkv~~	Assigned To	mkv => bugmaster
2014-02-10 17:39	~~mkv~~	Status	reviewed => tested
2014-02-14 12:00	apn	Changeset attached	=> occt master 3b010a74
2014-02-14 12:00	apn	Assigned To	bugmaster => apn
2014-02-14 12:00	apn	Status	tested => verified
2014-02-14 12:00	apn	Resolution	open => fixed
2014-04-04 12:36	~~abv~~	Target Version	6.7.1 => 6.8.0
2014-11-11 12:47	~~aiv~~	Fixed in Version	=> 6.8.0
2014-11-11 12:51	~~aiv~~	Status	verified => closed

View Issue Details

Relationships

Activities

Related Changesets

Issue History