View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023746CommunityOCCT:Data Exchangepublic2013-02-07 23:022013-12-19 13:56
Reportertodcourtney Assigned Toika  
PriorityurgentSeverityblock 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.2 
Target Version6.7.0Fixed in Version6.7.0 
Summary0023746: IGES wheel model fails to load when OCCT unit is meters
DescriptionWe discovered a problem with a airplane IGES model. When I load the model into our tool, based on OCCT 6.5.2, I can see all parts of the airplane fine. When I save the model from our tool it saves fine. When I reload the saved file, several of the wheels are missing.

To debug the problem I have created a test program. I also removed a single wheel from the original IGES file.

It appears that the problem is caused by setting:
  Interface_Static::SetCVal ("xstep.cascade.unit", "M");

in our code.

I can load the files fine with the Rhino v4 CAD tool. I can also load them fine with my tool, if I comment out the above "xstep.cascade.unit" line.
Steps To ReproduceI created a simple test program to diagnose and reproduce this issue. It is 'testloadsave.cpp'. It loads a file, translates it, populates a writer, and saves. It takes 3 arguments:

USAGE: testLoadSave <input file> <output file> <1=meters,2=millimeters>

if the last option is 1, the "xstep.cascade.unit" is set to "M". If its any other number, the default of "MM" is used.

to reproduce, I ran these commands ('#' are comments, '>' are commands)

# load original model, keep in MM, save
> ../testLoadSave wheel.igs wheel-0.igs 0 >out-0.txt
# load original model, convert to M, save
> ../testLoadSave wheel.igs wheel-1.igs 1 > out-1.txt

# load "MM" model, keep in MM, save
> ../testLoadSave wheel-0.igs wheel-0-0.igs 0 > out-0-0.txt
# load "MM" model, convert to M, save
> ../testLoadSave wheel-0.igs wheel-0-1.igs 1 > out-0-1.txt

# load "M" model, keep in MM, save
> ../testLoadSave wheel-1.igs wheel-1-0.igs 0 > out-1-0.txt
# load "M" model, convert to M, save
> ../testLoadSave wheel-1.igs wheel-1-1.igs 1 > out-1-1.txt

the source code, wheel*.igs and out*.txt files are all in the attached zip file.

If you look at the 'out' files, two of them will have "BAD" in them. They are the ones that convert to Meters for the second load/save.

If you look at the file sizes and entity lists, you can see that they change for each of the files.

I believe that there is a problem with the tolerances when the files are converted to meters. I have spent several days trying to track down the problem, but I am not yet enough of an OCCT expert to find the solution.
Additional information
and documentation updates		this issue is the same as two forum posts:

http://www.opencascade.org/org/forum/thread_24409/?forum=3
http://www.opencascade.org/org/forum/thread_24348/?forum=3
TagsNo tags attached.
Test case numberbugs iges(003) bug23746

Attached Files

  • occt-bugreport.zip (168,479 bytes)

Activities

todcourtney

2013-02-07 23:02

reporter  

occt-bugreport.zip (168,479 bytes)

szv

2013-02-12 14:28

manager   ~0023308

By default, the static parameter "write.iges.brep.mode" is set to "Faces". In the case of wheel.igs, it leads to the loss of connectivity within the model during writing, and consequent errors in multiple reading-writing cycles. Setting the static parameter "write.iges.brep.mode" to "BRep" solves the problem.

Please confirm if this solution works on your side.

Here is a sample script to reproduce in Draw:

pload MODELING DATAEXCHANGE
param write.iges.brep.mode BRep
dall
tpclear
newmodel
param xstep.cascade.unit MM
igesbrep D:/occt-bugreport/wheel.igs a *
tpclear
newmodel
brepiges a D:/occt-bugreport/occ-wheel-0.igs
tpclear
newmodel
param xstep.cascade.unit M
igesbrep D:/occt-bugreport/wheel.igs b *
tpclear
newmodel
brepiges b D:/occt-bugreport/occ-wheel-1.igs
tpclear
newmodel
param xstep.cascade.unit MM
igesbrep D:/occt-bugreport/occ-wheel-0.igs a0 *
tpclear
newmodel
brepiges a0 D:/occt-bugreport/occ-wheel-0-0.igs
tpclear
newmodel
param xstep.cascade.unit M
igesbrep D:/occt-bugreport/occ-wheel-0.igs b0 *
tpclear
newmodel
brepiges b0 D:/occt-bugreport/occ-wheel-0-1.igs
tpclear
newmodel
param xstep.cascade.unit MM
igesbrep D:/occt-bugreport/occ-wheel-1.igs a1 *
tpclear
newmodel
brepiges a1 D:/occt-bugreport/occ-wheel-1-0.igs
tpclear
newmodel
param xstep.cascade.unit M
igesbrep D:/occt-bugreport/occ-wheel-1.igs b1 *
tpclear
newmodel
brepiges b1 D:/occt-bugreport/occ-wheel-1-1.igs

todcourtney

2013-04-22 21:24

reporter   ~0024243

I believe that OCCT should be able to save this geometry using either output mode. It is good to know that BREP mode could be used as a work-around, but I feel that the BREP entities are less-likely to be compatible or well-supported by 3rd-party CAD tools compared to the FACE entities like 144 and 142.

Also, this CAD model was originally produced by our customer's software based on a non-OCCT CAD library. We do not have the ability to change that software to use BREP entities. We need to be able to import those CAD models into our OCCT-based tools with confidence that we are not loosing or corrupting the geometry.

Our work-around was to stop using the unit-conversion features of OCCT and to explicitly convert the geometry to/from MM in the application code, after the CAD file is loaded and before it is saved. This seems to work with the FACES mode but causes a lot of extra effort on our part. It would be better to have this issue fixed inside OCCT.

todcourtney

2013-05-09 06:31

reporter   ~0024352

I keep getting reminders about this ticket, but there is nothing that I can do. I do not think this ticket should be resolved, but that is the only option I have. What can I do to change the state of this ticket to something besides feedback (the current state) or resolved (it is not resolved)?

ika

2013-06-26 14:17

developer   ~0024883

Add check for too small distances between loops of edges during edge's reordering.

Branch CR23746 is ready to be reviewed.

Dear GKA,
Please review.

ika

2013-07-18 11:12

developer   ~0025108

Fix writing TrimmedSurface (Type 144).
Fix checking for too small distances between loops of edges during edge's reordering.
Add checking for too small BSpline segments during reading and writing IGES.
Fix wire splitting by adding checking that vertexes same not only in 3d, but in 2d too.

Branch CR23746 was updated.

Dear GKA,
Please review.

gka

2013-07-18 15:21

developer   ~0025110

In 2d space it is necessary to use tolerance vertex recomputed through resolution surface.

ika

2013-07-18 15:46

developer   ~0025111

Dear GKA,
Thank you for your remarks, branch CR23746 was updated.
Please review.

gka

2013-07-18 15:49

developer   ~0025112

Branch CR23746 is ready to test.

gka

2013-07-18 15:50

developer   ~0025113

Branch CR23746 is ready to test.

mkv

2013-07-19 14:17

tester   ~0025122

Dear BugMaster,

Branch CR23746 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: f1fde3329b5554e1a5356794fc7ff93a8560f3a7

Regressions:
http://occt-tests/CR23746-master-occt/Debian60-64/summary.html
http://occt-tests/CR23746-master-occt/Windows-32-VC9/summary.html
de iges_1(001) A4, A5, A6, A8, D1, H2, H5, H7, I2, J2, J3, K2, K3, K4, K8, L5, L9, N3, N4, O4, P7, Q2, R4, R6, R7
de iges_2(002) A1, A5, B2, B3, B8, B9, C2, C3, C5, D3, E6, G2, G8, I9, J1
de iges_3(003) A4, A5, A7, B1
de step_1(004) E3, E6
de step_5(008) A1

Improvements:
http://occt-tests/CR23746-master-occt/Debian60-64/summary.html
http://occt-tests/CR23746-master-occt/Windows-32-VC9/summary.html
de iges_1(001) I7, K6, K7, M9, R1
de iges_2(002) A2, C9, D1, F1, F8, G3, G6, G9, H5, H6, I8
de iges_3(003) A3, A6

Testing cases:
bugs iges(003) bug23746
It is neseccary to correct bugs iges(003) bug23746 : it is OK with fix and it is OK without fix.

Testing on Linux:
Total MEMORY difference: 355360276 / 355650848
Total CPU difference: 47580.30000000041 / 40205.49000000056

Testing on Windows:
Total MEMORY difference: 418366672 / 418133236
Total CPU difference: 29330.5 / 27771.046875

There are not differences in images found by testdiff.

ika

2013-07-23 14:12

developer   ~0025135

Dear MKV,

All regressions were analyzed and the results are:

iges_3 A5: because of new check for too small bspline segments (one knot) some faces didn't lost, so number of them after second reading became more, than in reference data.

step_1 E3:one of wires wasn't splitting (it really shouldn't splitting) due to changes in shape healing.

step_3 E6, step_5 A1:some wires weren't splitting, so appropriate faces weren't splitting too.

Other tests failed because of difference in numbers of vertices, edges and shared edges between reference and current data, this is due to the fact that after fix some couples of edges can be reading from IGES like seams and some edges aren't lose because of checking for too small bspline segments.

So I think, that these tests are not regressions, but correct behavior.

Test case OK without fix because it should be
"param write.iges.brep.mode Faces", please check it.

apn

2013-07-23 19:20

administrator   ~0025140

All testing cases with regressions and improvements were corrected according to new reference data.
Test case bugs iges bug23746 - OK (modified).

Related Changesets

occt: master fdabc211

2013-07-25 08:39:12

ika

Details Diff		 0023746: IGES wheel model fails to load when OCCT unit is meters
Add check for too small distances during edges reordering
Fix writing TrimmedSurface (Type 144).
Fix checking for too small distances between loops of edges during edge's reordering.
Add checking for too small BSpline segments during reading and writing IGES.
Fix wire splitting by adding checking that vertexes same not only in 3d, but in 2d too.
use tolerance of vertexes recomputed through resolution surface, not 2d curves.
Adding test case for this fix
Modified test case bugs iges bug23746 and cases in group de according to new reference data		 Affected Issues
0023746
mod - src/BRepToIGES/BRepToIGES_BRShell.cxx Diff File
mod - src/GeomToIGES/GeomToIGES_GeomCurve.cxx Diff File
mod - src/IGESGeom/IGESGeom_ToolTrimmedSurface.cxx Diff File
mod - src/IGESToBRep/IGESToBRep_BasicCurve.cxx Diff File
mod - src/IGESToBRep/IGESToBRep_BRepEntity.cxx Diff File
mod - src/IGESToBRep/IGESToBRep_TopoSurface.cxx Diff File
mod - src/ShapeAnalysis/ShapeAnalysis_WireOrder.cxx Diff File
mod - src/ShapeFix/ShapeFix_Face.cxx Diff File
add - tests/bugs/iges/bug23746 Diff File
mod - tests/de/iges_1/A4 Diff File
mod - tests/de/iges_1/A5 Diff File
mod - tests/de/iges_1/A6 Diff File
mod - tests/de/iges_1/A8 Diff File
mod - tests/de/iges_1/D1 Diff File
mod - tests/de/iges_1/H2 Diff File
mod - tests/de/iges_1/H5 Diff File
mod - tests/de/iges_1/H7 Diff File
mod - tests/de/iges_1/I2 Diff File
mod - tests/de/iges_1/I7 Diff File
mod - tests/de/iges_1/J2 Diff File
mod - tests/de/iges_1/J3 Diff File
mod - tests/de/iges_1/K2 Diff File
mod - tests/de/iges_1/K3 Diff File
mod - tests/de/iges_1/K4 Diff File
mod - tests/de/iges_1/K6 Diff File
mod - tests/de/iges_1/K7 Diff File
mod - tests/de/iges_1/K8 Diff File
mod - tests/de/iges_1/L5 Diff File
mod - tests/de/iges_1/L9 Diff File
mod - tests/de/iges_1/M9 Diff File
mod - tests/de/iges_1/N3 Diff File
mod - tests/de/iges_1/N4 Diff File
mod - tests/de/iges_1/O4 Diff File
mod - tests/de/iges_1/P7 Diff File
mod - tests/de/iges_1/Q2 Diff File
mod - tests/de/iges_1/R1 Diff File
mod - tests/de/iges_1/R4 Diff File
mod - tests/de/iges_1/R6 Diff File
mod - tests/de/iges_1/R7 Diff File
mod - tests/de/iges_2/A1 Diff File
mod - tests/de/iges_2/A2 Diff File
mod - tests/de/iges_2/A5 Diff File
mod - tests/de/iges_2/B2 Diff File
mod - tests/de/iges_2/B3 Diff File
mod - tests/de/iges_2/B8 Diff File
mod - tests/de/iges_2/B9 Diff File
mod - tests/de/iges_2/C2 Diff File
mod - tests/de/iges_2/C3 Diff File
mod - tests/de/iges_2/C5 Diff File
mod - tests/de/iges_2/C9 Diff File
mod - tests/de/iges_2/D1 Diff File
mod - tests/de/iges_2/D3 Diff File
mod - tests/de/iges_2/E6 Diff File
mod - tests/de/iges_2/F1 Diff File
mod - tests/de/iges_2/F8 Diff File
mod - tests/de/iges_2/G2 Diff File
mod - tests/de/iges_2/G3 Diff File
mod - tests/de/iges_2/G6 Diff File
mod - tests/de/iges_2/G8 Diff File
mod - tests/de/iges_2/G9 Diff File
mod - tests/de/iges_2/H5 Diff File
mod - tests/de/iges_2/H6 Diff File
mod - tests/de/iges_2/I8 Diff File
mod - tests/de/iges_2/I9 Diff File
mod - tests/de/iges_2/J1 Diff File
mod - tests/de/iges_3/A3 Diff File
mod - tests/de/iges_3/A4 Diff File
mod - tests/de/iges_3/A5 Diff File
mod - tests/de/iges_3/A6 Diff File
mod - tests/de/iges_3/A7 Diff File
mod - tests/de/iges_3/B1 Diff File
mod - tests/de/step_1/E3 Diff File
mod - tests/de/step_3/E6 Diff File
mod - tests/de/step_5/A1 Diff File

Issue History

Date Modified Username Field Change
2013-02-07 23:02 todcourtney New Issue
2013-02-07 23:02 todcourtney Assigned To => gka
2013-02-07 23:02 todcourtney File Added: occt-bugreport.zip
2013-02-12 14:18 szv Assigned To gka => szv
2013-02-12 14:18 szv Status new => assigned
2013-02-12 14:28 szv Note Added: 0023308
2013-02-12 14:28 szv Assigned To szv => todcourtney
2013-02-12 14:28 szv Status assigned => feedback
2013-04-22 21:24 todcourtney Note Added: 0024243
2013-05-09 06:31 todcourtney Note Added: 0024352
2013-05-09 09:17 abv Assigned To todcourtney => ika
2013-05-09 09:17 abv Status feedback => assigned
2013-06-26 14:17 ika Note Added: 0024883
2013-06-26 14:17 ika Assigned To ika => gka
2013-06-26 14:17 ika Status assigned => resolved
2013-07-18 11:12 ika Note Added: 0025108
2013-07-18 15:21 gka Note Added: 0025110
2013-07-18 15:22 gka Assigned To gka => ika
2013-07-18 15:22 gka Status resolved => assigned
2013-07-18 15:46 ika Note Added: 0025111
2013-07-18 15:46 ika Assigned To ika => gka
2013-07-18 15:46 ika Status assigned => resolved
2013-07-18 15:49 gka Note Added: 0025112
2013-07-18 15:49 gka Status resolved => assigned
2013-07-18 15:49 gka Status assigned => resolved
2013-07-18 15:50 gka Note Added: 0025113
2013-07-18 15:50 gka Status resolved => reviewed
2013-07-18 16:04 mkv Assigned To gka => mkv
2013-07-19 14:17 mkv Note Added: 0025122
2013-07-19 14:18 mkv Test case number => bugs iges(003) bug23746
2013-07-19 14:18 mkv Assigned To mkv => ika
2013-07-19 14:18 mkv Status reviewed => assigned
2013-07-23 14:12 ika Note Added: 0025135
2013-07-23 14:12 ika Assigned To ika => mkv
2013-07-23 14:12 ika Status assigned => feedback
2013-07-23 14:42 bugmaster Assigned To mkv => apn
2013-07-23 19:20 apn Note Added: 0025140
2013-07-24 09:32 apn Assigned To apn => bugmaster
2013-07-24 09:32 apn Status feedback => tested
2013-07-24 09:32 apn Target Version => 6.7.0
2013-07-26 12:33 ika Changeset attached => occt master fdabc211
2013-07-26 12:33 ika Assigned To bugmaster => ika
2013-07-26 12:33 ika Status tested => verified
2013-07-26 12:33 ika Resolution open => fixed
2013-12-19 13:52 bugmaster Status verified => closed
2013-12-19 13:56 bugmaster Fixed in Version => 6.7.0