View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023687CommunityOCCT:Data Exchangepublic2013-01-04 14:522013-04-29 15:21
ReporterPawel Assigned ToPawel  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.4 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023687: Two opposite conditions. The second condition is always false in ifselect_shareout.cxx
DescriptionIn lines 44, 45

 if (!modifier.IsNull()) {
    if (modifier.IsNull()) return Standard_False;

the second check is always 'false'.

The second if-clause can either be deleted or checked as first but I'm not sure about the logic (should the method return 'Standard_False' if there is no modifier?).
TagsNo tags attached.
Test case numberNot needed

Activities

abv

2013-01-04 17:24

manager   ~0022902

I suggest line 45 should be removed: this is safe as it will keep existing behavior, while recovering the complete logic of this tool seems to be not worth the candle

Pawel

2013-01-04 18:20

developer   ~0022904

Branch CR23687 pushed. Please review.

abv

2013-01-04 18:26

manager   ~0022906

No remarks, please test

mkv

2013-01-11 18:30

tester   ~0022949

Dear BugMaster,

Branch CR23687 (and products from GIT master) was compiled on Linux and
Windows platforms and tested.

Regressions:
Not detected

Improvements:
Not detected

Testing cases:
Not needed

Related Changesets

occt: master e1db25a9

2013-01-04 14:18:34

Pawel

Details Diff		 0023687: Two opposite conditions. The second condition is always false in ifselect_shareout.cxx

Deleted if-condition that was always false.		 Affected Issues
0023687
mod - src/IFSelect/IFSelect_ShareOut.cxx Diff File

Issue History

Date Modified Username Field Change
2013-01-04 14:52 Pawel New Issue
2013-01-04 14:52 Pawel Assigned To => bugmaster
2013-01-04 17:24 abv Note Added: 0022902
2013-01-04 18:20 Pawel Note Added: 0022904
2013-01-04 18:20 Pawel Status new => resolved
2013-01-04 18:26 abv Note Added: 0022906
2013-01-04 18:26 abv Status resolved => reviewed
2013-01-11 18:30 mkv Note Added: 0022949
2013-01-11 18:30 mkv Test case number => Not needed
2013-01-11 18:30 mkv Status reviewed => tested
2013-01-21 18:29 Pawel Changeset attached => occt master e1db25a9
2013-01-21 18:29 Pawel Assigned To bugmaster => Pawel
2013-01-21 18:29 Pawel Status tested => verified
2013-01-21 18:29 Pawel Resolution open => fixed
2013-04-23 13:36 aiv Status verified => closed
2013-04-29 15:21 aiv Fixed in Version => 6.6.0