View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023348 | Community | OCCT:DRAW | public | 2012-07-25 19:47 | 2012-11-16 13:17 |
| Reporter | Pawel | Assigned To | Pawel | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023348: Expression 'ii >= 0' is always true. Unsigned type value is always >= 0. | ||||
| Description | In Draw_Interpretor.cxx, line 391 Problem introduced after changing some variable to 'Standard_Size' | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
| related to | 0023072 | closed | Open CASCADE | Eliminate compiler warnings (level 3) on Windows / MSVC++ |
|
|
Corresponding git branch pushed. Please review. |
|
|
I have modified the code to use OSD_Path instead of parsing C strings; this makes the code more clear and also makes it working on Windows (where original path contains reversed slashes which were not considered). The new test case added: demo draw getsource Please review |
|
|
No remarks. Please forward for testing. |
|
|
Dear BugMaster, Branch CR23348 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regression: Not detected Improvements: Not detected Testing case: Not needed |
|
occt: master d33dea30 2012-08-03 09:28:27 Details Diff |
0023348: Expression 'ii >= 0' is always true. Unsigned type value is always >= 0. Redesigned the loop to work correctly with unsigned variables. Treatment of path to source file is rewritten using OSD_Path for more clarity Command getsourcefile corrected to return its result as Tcl string, and simplified Error in treatment of optional arguments in substituted puts is fixed in src/DrawResources/TestCommands.tcl Test case added: demo draw getsource |
Affected Issues 0023348 |
|
| mod - src/Draw/Draw_Interpretor.cxx | Diff File | ||
| mod - src/DrawResources/StandardCommands.tcl | Diff File | ||
| mod - src/DrawResources/TestCommands.tcl | Diff File | ||
| add - tests/demo/draw/getsource | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-25 19:47 | Pawel | New Issue | |
| 2012-07-25 19:47 | Pawel | Assigned To | => Pawel |
| 2012-07-25 19:48 | Pawel | Relationship added | related to 0023072 |
| 2012-07-26 12:59 | Pawel | Note Added: 0021159 | |
| 2012-07-26 12:59 | Pawel | Assigned To | Pawel => bugmaster |
| 2012-07-26 12:59 | Pawel | Status | new => resolved |
| 2012-07-27 08:48 |
|
Assigned To | bugmaster => Pawel |
| 2012-07-27 08:51 |
|
Note Added: 0021170 | |
| 2012-07-27 11:55 | Pawel | Note Added: 0021172 | |
| 2012-07-27 11:55 | Pawel | Assigned To | Pawel => bugmaster |
| 2012-07-27 11:55 | Pawel | Status | resolved => reviewed |
| 2012-07-31 10:03 | apn | Note Added: 0021188 | |
| 2012-07-31 10:04 | apn | Test case number | => Not needed |
| 2012-07-31 10:04 | apn | Status | reviewed => tested |
| 2012-08-06 16:35 | Pawel | Changeset attached | => occt master d33dea30 |
| 2012-08-06 16:35 | Pawel | Assigned To | bugmaster => Pawel |
| 2012-08-06 16:35 | Pawel | Status | tested => verified |
| 2012-08-06 16:35 | Pawel | Resolution | open => fixed |
| 2012-11-16 13:14 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:17 | bugmaster | Status | verified => closed |
