View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023336 | Community | OCCT:Data Exchange | public | 2012-07-20 16:54 | 2012-11-16 13:17 |
| Reporter | Pawel | Assigned To | Pawel | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.3 | ||||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023336: The 'strcmp' function returns 0 if corresponding strings are equal. | ||||
| Description | In RWStepShape_RWAngularLocation.cxx / RWStepShape_RWAngularSize.cxx there are code blocks: if (strcmp(text, ".EQUAL.")) aAngleSelection = StepShape_Equal; else if (strcmp(text, ".LARGE.")) aAngleSelection = StepShape_Large; else if (strcmp(text, ".SMALL.")) aAngleSelection = StepShape_Small; else ach->AddFail("Parameter #3 (angle_selection) has not allowed value"); if, for example, text equals to ".EQUAL." the 'strcmp' function will return '0' and so the execution will process to else if (strcmp(text, ".LARGE.")) aAngleSelection = StepShape_Large; I don't think it was intended. I think at this point a pattern like: if (strcmp(text, "STRING_TO_COMPARE") == 0) ...; was intended. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Corresponding git branch pushed. Please review. |
|
|
No remarks, please test |
|
|
Dear BugMaster, The workbenches KAS:dev:apn-23336-occt (GIT branch CR23336) KAS:dev:apn-23336-products (GIT master) were compiled on Linux platform and tested. Regression: Not detected Improvements: Not detected Testing case: Not needed See results in /QADisk/occttests/results/KAS/dev/apn-23336-products_23072012/lin See reference results in /QADisk/occttests/results/KAS/dev/products-20120706-opt_06072012/lin See test cases in /QADisk/occttests/tests/ED |
|
occt: master fafad173 2012-07-20 12:56:44 Details Diff |
0023336: The 'strcmp' function returns 0 if corresponding strings are equal. Checking if the return value from 'strcmp' is '0'. |
Affected Issues 0023336 |
|
| mod - src/RWStepShape/RWStepShape_RWAngularLocation.cxx | Diff File | ||
| mod - src/RWStepShape/RWStepShape_RWAngularSize.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-20 16:54 | Pawel | New Issue | |
| 2012-07-20 16:54 | Pawel | Assigned To | => Pawel |
| 2012-07-20 16:57 | Pawel | Note Added: 0021090 | |
| 2012-07-20 16:57 | Pawel | Assigned To | Pawel => bugmaster |
| 2012-07-20 16:57 | Pawel | Status | new => resolved |
| 2012-07-20 17:51 | Pawel | Relationship added | related to 0023337 |
| 2012-07-20 18:30 | Pawel | Relationship added | related to 0023339 |
| 2012-07-23 13:52 |
|
Note Added: 0021107 | |
| 2012-07-23 13:52 |
|
Status | resolved => reviewed |
| 2012-07-24 11:59 | apn | Note Added: 0021136 | |
| 2012-07-24 11:59 | apn | Test case number | => Not needed |
| 2012-07-24 11:59 | apn | Status | reviewed => tested |
| 2012-07-30 16:31 | Pawel | Changeset attached | => occt master fafad173 |
| 2012-07-30 16:32 | Pawel | Assigned To | bugmaster => Pawel |
| 2012-07-30 16:32 | Pawel | Status | tested => verified |
| 2012-07-30 16:32 | Pawel | Resolution | open => fixed |
| 2012-11-16 13:14 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:17 | bugmaster | Status | verified => closed |
