MantisBT
Mantis Bug Tracker Workflow

View Revisions: Issue #22488 All Revisions ] Back to Issue ]
Summary 0022488: Typo in Geom2d_BSplineCurve::LocateU() - which uses a value not adjusted to period for periodic B-Splines
Revision 2011-11-24 15:05 by szy
Description Contribution from RLN.
Typo in Geom2d_BSplineCurve::LocateU() - which uses a value not adjusted to
period for periodic B-Splines.
The bug shows up on periodic B-Splines when due to rounding issues the U
parameter is slightly below the min knot (e.g. 0 vs 1e-18). NewU bumps up to 0 +
period but due to wrong check, another
if branch is chosen (one which uses BSplCLib::Hunt()) and respectively an
exception later is thrown due to access beyond the max knot item.
Similar code in Geom_BSplineCurve and Geom_BSplineSurface is correct.
Another minor improvements:
 - computation of Abs(ParametricTolerance) only once.
 - removed Abs(ParametricTolerance) in the 3rd and 4th branch as they are
irrelevant after 1st and 2nd
Revision 2011-05-10 15:31 by szy
Description Contribution from RLN.
Typo in Geom2d_BSplineCurve::LocateU() - which uses a value not adjusted to
period for periodic B-Splines.
The bug shows up on periodic B-Splines when due to rounding issues the U
parameter is slightly below the min knot (e.g. 0 vs 1e-18). NewU bumps up to 0 +
period but due to wrong check, another
if branch is chosen (one which uses BSplCLib::Hunt()) and respectively an
exception later is thrown due to access beyond the max knot item.
Similar code in Geom_BSplineCurve and Geom_BSplineSurface is correct.
Another minor improvements:
 - computation of Abs(ParametricTolerance) only once.
 - removed Abs(ParametricTolerance) in the 3rd and 4th branch as they are
irrelevant after 1st and 2nd


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker