MantisBT
Mantis Bug Tracker Workflow

View Revisions: Issue #31424 All Revisions ] Back to Issue ]
Summary 0031424: Visualization - stop using Prs3d_Drawer::HLRAngle() parameter
Revision 2020-03-13 00:36 by kgv
Description There is a massive confusion within two Prs3d_Drawer parameters: HLRAngle() and DeviationAngle(). For some reason, HLRAngle() has been used for BRepMesh input parameters, while its name clearly indicates its reference to HLR algorithm.

These parameters have different defaults, so that this substitution is unsafe:
  myDeviationAngle                (12.0 * M_PI / 180.0),
  myHLRAngle                      (20.0 * M_PI / 180.0),


It is desired to break this endless loop and stop using HLRAngle() in wrong places. For smooth porting, it might be necessary:
- Changing default value of DeviationAngle() property to much current HLRAngle.
- Marking HLRAngle()/SetHLRAngle() as deprecated with redirection to DeviationAngle() property.

The main purpose is to allow safe transition of existing projects relying on HLRAngle() property misuse for triangulation algorithm, as actual HLR parameter is much rarely used.
Revision 2020-03-11 15:15 by kgv
Description There is a massive confusion within two Prs3d_Drawer parameters: HLRAngle() and DeviationAngle(). For some reason, HLRAngle() has been used for BRepMesh input parameters, while its name clearly indicates its reference to HLR algorithm.

These parameters have different defaults, so that this substitution is unsafe:
  myDeviationAngle                (12.0 * M_PI / 180.0),
  myHLRAngle                      (20.0 * M_PI / 180.0),


It is desired to break this endless loop and stop using HLRAngle() in wrong places. For smooth porting, it might be necessary:
- Changing default value of DeviationAngle() property to much current HLRAngle.
- Marking HLRAngle()/SetHLRAngle() as deprecated with redirection to DeviationAngle() property.
- Introduce new getters/setters for HLR angle property and use it only within HLR algo.

The main purpose is to allow safe transition of existing projects relying on HLRAngle() property misuse for triangulation algorithm, as actual HLR parameter is much rarely used.


Copyright © 2000 - 2020 MantisBT Team
Powered by Mantis Bugtracker