MantisBT
Mantis Bug Tracker Workflow

View Revisions: Issue #24729 All Revisions ] Back to Issue ]
Summary 0024729: Duplicate code to compute the normals for TopoDS_Face
Revision 2017-08-08 08:46 by kgv
Description There are duplicate code to compute the normals for the TopoDS_Face:
1. void StdPrs_ToolShadedShape::Normal (const TopoDS_Face& theFace,
                                     Poly_Connect& thePolyConnect,
                                     TColgp_Array1OfDir& theNormals)

2. In StlTransfer.cxx, also have the function to compute normals for surface:
   static void Normal(const TopoDS_Face& aFace,
           Poly_Connect& pc,
           TColgp_Array1OfDir& Nor)
   Though the normals are calcuted for the TopoDS_Face, but when output them to STL file, do not use these normals. The normals in STL file are normal of the triangle, not the vertex. So the function Normal() in StlTransfer.cxx can be removed.
Revision 2017-07-10 10:26 by kgv
Description There are duplicate code to compute the normals for the TopoDS_Face:
1. void StdPrs_ToolShadedShape::Normal (const TopoDS_Face& theFace,
                                     Poly_Connect& thePolyConnect,
                                     TColgp_Array1OfDir& theNormals)

2. In StlTransfer.cxx, also have the function to compute normals for surface:
   static void Normal(const TopoDS_Face& aFace,
           Poly_Connect& pc,
           TColgp_Array1OfDir& Nor)
   Though the normals are calcuted for the TopoDS_Face, but when output them to STL file, do not use these normals. The normals in STL file are normal of the triangle, not the vertex. So the function Normal() in StlTransfer.cxx can be removed.

3. Poly::ComputeNormals()
Revision 2014-03-15 10:06 by eryar
Description There are duplicate code to compute the normals for the TopoDS_Face:
1. void StdPrs_ToolShadedShape::Normal (const TopoDS_Face& theFace,
                                     Poly_Connect& thePolyConnect,
                                     TColgp_Array1OfDir& theNormals)

2. In StlTransfer.cxx, also have the function to compute normals for surface:
   static void Normal(const TopoDS_Face& aFace,
           Poly_Connect& pc,
           TColgp_Array1OfDir& Nor)
   Though the normals are calcuted for the TopoDS_Face, but when output them to STL file, do not use these normals. The normals in STL file are normal of the triangle, not the vertex. So the function Normal() in StlTransfer.cxx can be removed.


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker