MantisBT
Mantis Bug Tracker Workflow

View Revisions: Issue #27988 All Revisions ] Back to Issue ]
Summary 0027988: Visualization, AIS_InteractiveContext - fix inconsistent methods for setting highlight styles
Revision 2016-10-21 12:52 by kgv
Description Patch for 0027818 has introduced the following new methods:
+  Handle(Graphic3d_HighlightStyle)& ChangeHighlightStyle()
+  {
+    return myHiStyle;
+  }
+
+  Handle(Graphic3d_HighlightStyle)& ChangeSelectionStyle()
+  {
+    return mySelStyle;
+  }


The "Change" syntax makes sense only in context of primitive types, where it can be used in expressions like "ChangeValue() += 33.0", but not with Handle types.
It is better changing these methods to "Set" syntax for easier lookup of class properties.
Revision 2016-10-21 12:39 by kgv
Description Patch for 0027818 has introduced the following new methods:
+  Handle(Graphic3d_HighlightStyle)& ChangeHighlightStyle()
+  {
+    return myHiStyle;
+  }
+
+  Handle(Graphic3d_HighlightStyle)& ChangeSelectionStyle()
+  {
+    return mySelStyle;
+  }


The "Change" syntax makes sense only in context of primitive types, where it can be used in expressions like "ChangeValue() += 33.0", but not with Handle types. It is better changing these methods to "Set" syntax for easier lookup of class properties.


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker