View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0026726 | Open CASCADE | OCCT:DRAW | public | 2015-09-25 17:24 | 2016-04-20 15:50 |
| Reporter | Assigned To | bugmaster | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 7.0.0 | Fixed in Version | 7.0.0 | ||
| Summary | 0026726: Draw Harness, ViewerTest - AIS_InteractiveContext::EraseSelected() lacks test case | ||||
| Description | AIS_InteractiveContext::EraseSelected() lacks test case | ||||
| Steps To Reproduce | bugs vis bug26726 | ||||
| Tags | No tags attached. | ||||
| Test case number | bugs vis bug26726 | ||||
|
|
Branch CR26726 has been created by isk. SHA-1: d284151bae6ff31138681228c3e987a8b645a585 Detailed log of new commits: Author: isk Date: Fri Sep 25 17:38:15 2015 +0300 0026726: Visualization: AIS_InteractiveContext::EraseSelected() lacks test case. Update draw command ViewerTest::Erase(). |
|
|
Dear Ilya, I have one small remark: please, consider using EraseSelected (Standard_False) to avoid excessive viewer update. |
|
|
Branch CR26726 has been updated forcibly by isk. SHA-1: ee298d134c5bbb90bb31137f07cbf1393b499265 |
|
|
Dear bugmaster, please test patch in branch CR26726. |
|
|
Branch CR26726 has been updated forcibly by apv. SHA-1: c6879b84f0da2aac533d4f2a37ade658cb4737de |
|
|
Branch CR26726 has been rebased on the current master |
|
|
Dear BugMaster, Branch CR26726 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: c6879b84f0da2aac533d4f2a37ade658cb4737de Number of compiler warnings: occt component: Linux: 13 (13 on master) Windows: 0 (0 on master) products component: Linux: 39 (39 on master) Windows: 0 (0 on master) Regressions/Differences: http://occt-tests/CR26726-master-occt-64/Debian70-64/summary.html http://occt-tests/CR26726-master-occt-64/Windows-64-VC10/summary.html bugs vis bug24966 Testing cases: bugs vis bug26726 - OK http://occt-tests/CR26726-master-occt-64/Debian70-64/bugs/vis/bug26726.html http://occt-tests/CR26726-master-occt-64/Windows-64-VC10/bugs/vis/bug26726.html Testing on Linux: Total MEMORY difference: 92512284 / 93306890 [-0.85%] Total CPU difference: 19717.509999999453 / 19848.729999999236 [-0.66%] Testing on Windows: Total MEMORY difference: 57919761 / 57928042 [-0.01%] Total CPU difference: 17715.114757698993 / 17726.846032899077 [-0.07%] |
|
|
Dear isk, Branch CR26726 has been rejected due to: - regressions/differences/improvements |
|
|
Branch CR26726 has been updated forcibly by isk. SHA-1: 7ddaa3e0d6eccd867a88e53b5718dc55f89d36db |
|
|
Branch CR26726 was rebased on current master. |
|
|
Dear Varvara, Please review the branch CR26726. |
|
|
+ const Standard_Boolean aHasOpenedContext = aCtx->HasOpenedContext();
// Erase selected objects
the following comment is for entire "if" block - so it is better keeping it at the first line in the block. |
|
|
Branch CR26726 has been updated forcibly by isk. SHA-1: 4476e94621275efa48a5c888b7afaf1e88134101 |
|
|
Move the comment. |
|
|
Branch CR26726 has been updated forcibly by isk. SHA-1: a8110c379f184791b4f9722824172bd01c0b7f5c |
|
|
Update test case. It checks colors now. |
|
|
Please test the patch. |
|
|
Branch CR26726 has been updated forcibly by apv. SHA-1: 3a41881c6f7ab6f6a679753c5c9a00cb5800e66d |
|
|
Branch CR26726 has been rebased on the current master |
|
|
Dear BugMaster, Branch CR26726 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested. SHA-1: 3a41881c6f7ab6f6a679753c5c9a00cb5800e66d Number of compiler warnings: occt component: Linux: 0 (0 on master) Windows: 0 (0 on master) MacOS: 1 (1 on master) products component: Linux: 36 (36 on master) Windows: 0 (0 on master) Regressions/Differences: Not detected Testing cases: bugs vis bug26726 - OK http://occt-tests/CR26726-master-occt-64/Debian70-64/bugs/vis/bug26726.html http://occt-tests/CR26726-master-occt-64/Windows-64-VC10/bugs/vis/bug26726.html Testing on Linux: Total MEMORY difference: 89640207 / 89398107 [+0.27%] Total CPU difference: 19068.98000000005 / 19103.799999999923 [-0.18%] Testing on Windows: Total MEMORY difference: 57285159 / 57304383 [-0.03%] Total CPU difference: 17942.111812799227 / 18573.837862298933 [-3.40%] |
|
|
Branch CR26726 has been deleted by kgv. SHA-1: 3a41881c6f7ab6f6a679753c5c9a00cb5800e66d |
|
occt: master 671b6fe0 2016-01-29 07:34:22
Committer: bugmaster Details Diff |
0026726: Draw Harness, ViewerTest - AIS_InteractiveContext::EraseSelected() lacks test case Update draw command ViewerTest::Erase(). |
Affected Issues 0026726 |
|
| mod - src/ViewerTest/ViewerTest.cxx | Diff File | ||
| add - tests/bugs/vis/bug26726 | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-09-25 17:24 |
|
New Issue | |
| 2015-09-25 17:24 |
|
Assigned To | => kgv |
| 2015-09-25 17:25 |
|
Assigned To | kgv => isk |
| 2015-09-25 17:43 | git | Note Added: 0046153 | |
| 2015-09-25 17:44 |
|
Assigned To | isk => abv |
| 2015-09-25 17:44 |
|
Status | new => resolved |
| 2015-09-25 17:44 |
|
Steps to Reproduce Updated | |
| 2015-09-25 19:08 |
|
Assigned To | abv => vpa |
| 2015-09-25 20:00 |
|
Note Added: 0046169 | |
| 2015-09-25 20:00 |
|
Assigned To | vpa => isk |
| 2015-09-25 20:00 |
|
Status | resolved => assigned |
| 2015-09-28 07:26 |
|
Steps to Reproduce Updated | |
| 2015-09-28 08:03 | git | Note Added: 0046180 | |
| 2015-09-28 08:03 |
|
Assigned To | isk => vpa |
| 2015-09-28 08:03 |
|
Status | assigned => resolved |
| 2015-09-28 11:50 |
|
Note Added: 0046194 | |
| 2015-09-28 11:50 |
|
Assigned To | vpa => bugmaster |
| 2015-09-28 11:50 |
|
Status | resolved => reviewed |
| 2015-09-28 12:45 |
|
Relationship added | related to 0026628 |
| 2015-09-28 14:23 |
|
Assigned To | bugmaster => apv |
| 2015-09-28 14:49 | git | Note Added: 0046218 | |
| 2015-09-28 14:49 |
|
Note Added: 0046219 | |
| 2015-09-29 14:21 |
|
Test case number | => bugs vis bug25726 |
| 2015-09-29 14:25 |
|
Note Added: 0046257 | |
| 2015-09-29 14:25 |
|
Assigned To | apv => isk |
| 2015-09-29 14:25 |
|
Status | reviewed => assigned |
| 2015-09-29 14:25 |
|
Note Added: 0046258 | |
| 2015-12-28 10:59 | kgv | Category | OCCT:Visualization => OCCT:DRAW |
| 2015-12-28 10:59 | kgv | Target Version | 7.0.0 => 7.1.0 |
| 2015-12-28 10:59 | kgv | Summary | Visualization: AIS_InteractiveContext::EraseSelected() lacks test case => Draw Harness, ViewerTest - AIS_InteractiveContext::EraseSelected() lacks test case |
| 2016-01-28 16:47 | git | Note Added: 0050211 | |
| 2016-01-28 16:49 |
|
Note Added: 0050213 | |
| 2016-01-28 16:52 |
|
Note Added: 0050215 | |
| 2016-01-28 16:52 |
|
Assigned To | isk => vpa |
| 2016-01-28 16:52 |
|
Status | assigned => resolved |
| 2016-01-29 08:50 | kgv | Note Added: 0050220 | |
| 2016-01-29 09:20 | git | Note Added: 0050221 | |
| 2016-01-29 09:21 |
|
Note Added: 0050222 | |
| 2016-01-29 10:35 | git | Note Added: 0050223 | |
| 2016-01-29 10:36 |
|
Note Added: 0050224 | |
| 2016-01-30 16:19 | kgv | Note Added: 0050261 | |
| 2016-01-30 16:19 | kgv | Assigned To | vpa => bugmaster |
| 2016-01-30 16:19 | kgv | Status | resolved => reviewed |
| 2016-01-30 16:19 | kgv | Target Version | 7.1.0 => 7.0.0 |
| 2016-02-01 12:27 |
|
Assigned To | bugmaster => apv |
| 2016-02-01 15:30 | git | Note Added: 0050307 | |
| 2016-02-01 15:31 |
|
Note Added: 0050308 | |
| 2016-02-02 11:43 |
|
Test case number | bugs vis bug25726 => bugs vis bug26726 |
| 2016-02-02 13:52 |
|
Note Added: 0050337 | |
| 2016-02-02 13:52 |
|
Assigned To | apv => bugmaster |
| 2016-02-02 13:52 |
|
Status | reviewed => tested |
| 2016-02-05 12:49 | bugmaster | Changeset attached | => occt master 671b6fe0 |
| 2016-02-05 12:49 | bugmaster | Status | tested => verified |
| 2016-02-05 12:49 | bugmaster | Resolution | open => fixed |
| 2016-04-17 13:18 | git | Note Added: 0052836 | |
| 2016-04-20 15:43 |
|
Fixed in Version | => 7.0.0 |
| 2016-04-20 15:50 |
|
Status | verified => closed |
